Closed
Bug 891757
Opened 11 years ago
Closed 10 years ago
"Additional hours worked" displayed inline with comments is now superfluous
Categories
(bugzilla.mozilla.org Graveyard :: Extensions: InlineHistory, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mail, Assigned: mail)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.88 KB,
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
(taking from BRC bug) Now that Bugzilla displays bug changes inline with comments (which is a really nice feature, by the way!) the old "Additional hours worked" is superfluous. It just repeats the same value that is displayed below it in the list of changes. For example https://bugzilla.redhat.com/show_bug.cgi?id=962901#c12 which displays: Dan Callaghan 2013-05-22 14:39:27 EST Additional hours worked: 1.1 Hours Worked: 1.1 Status: POST → MODIFIED Hours Left: 2.0 → 0.0
Attachment #773135 -
Flags: review?(glob)
|
Assignee | |
Updated•11 years ago
|
Comment on attachment 773135 [details] [diff] [review] v1 patch Review of attachment 773135 [details] [diff] [review]: ----------------------------------------------------------------- this looks good, but i'd like to avoid calling getElementsByClassName() more than once as it's expensive (especially when there are a lot of comments). can you please combine all three calls into a single loop.
Attachment #773135 -
Flags: review?(glob) → review-
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #773135 -
Attachment is obsolete: true
Attachment #8363457 -
Flags: review?(glob)
Comment on attachment 8363457 [details] [diff] [review] v2 patch r=glob thankyou :)
Attachment #8363457 -
Flags: review?(glob) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git cc18ce2..3351341 4.2 -> 4.2 To ssh://gitolite3@git.mozilla.org/bugzilla/extensions/InlineHistory.git e3f8471..2660ea3 master -> master
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Comment 5•9 years ago
|
||
Does InlineHistory work with Bugzilla 5 or was the Additional Hours Worked change introduced before 5? Or should I make no assumptions? I'm asking because the README markdown only mentions up to 4.4
|
||
Updated•5 years ago
|
Product: bugzilla.mozilla.org → bugzilla.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•