891767 - Domain auto-completion only kicks in after typing a dot

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Peter Retzer (:pretzer)]

Bug 858340 introduced domain auto-completion for the awesomebar. For me, URLs get only autocompleted after typing a dot. So for for example if I have 'bugzilla.mozilla.org' as one of my top sites and start typing, no auto-completion kicks in if I type only 'bugzilla'. But if I add the dot, so that I typed 'bugzilla.', the domain gets auto-completed to 'bugzilla.mozilla.org'.

Device: Samsung Galaxy S2, Android 4.1.2
VKB: tested both the stock VKB as well as SwiftKey

Not sure if this is a regression, or was happening since the initial landing of the feature, because I only had the chance to try it recently.

Comment 1

[Wesley Johnston (:wesj)]

It may be a speed issue, but I'm guessing you checked that. i.e. type 'b' and wait a bit?

It also may just be the algorithm. We loop through the top 20 awesomebar results and find any that start with 'b'. First one we find, we autocomplete. Maybe none show up for you until you've typed that much. I capped it at 20 to try and help with performance. We could expand that.

Alternatively, mfinkle and I talked once about using a special query just for this (maybe if we just sort by LAST_VISITED/VISIT_COUNT and LIMIT 1 in that case its enough to make it pretty fast...)

Comment 2

[Peter Retzer (:pretzer)]

(In reply to Wesley Johnston (:wesj) from comment #1)
> It may be a speed issue...

It can't be a speed issue. I've tried waiting up to 30 secs after typing 'b' or 'bugzilla' and nothing happens. But the auto-completion comes up in milliseconds after typing the dot.

> It also may just be the algorithm...

It also seems like it's not the algorithm, because I did clear my private data before and only had bugzilla in my top sites (other than the default bookmarks).

Can you reproduce with these STR?
1) Clear private data
2) Visit 'bugzilla.mozilla.org'
3) Close the bugzilla tab
4) type 'bugzilla' into the awesombar and see that no auto-completion is happening
5) type the extra '.' and see auto-completion kicking in

> Alternatively, mfinkle and I talked once about using a special query just
> for this (maybe if we just sort by LAST_VISITED/VISIT_COUNT and LIMIT 1 in
> that case its enough to make it pretty fast...)

CC'ed mfinkle to loop him in.

Comment 3

[Peter Retzer (:pretzer)]

Aaron, can you reproduce given the STR in comment 2?

Comment 4

[Aaron Train [:aaronmt]]

No. The moment I type 'b', I get completion for 'ugzilla.mozilla.org'.

Comment 5

[Peter Retzer (:pretzer)]

Attachment: logcat

Okay, thank you for testing. I recorded a log while reproducing the issue, not sure if that helps in this case. Let me know if I can do anything else to help understand the problem.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

I wonder if Peter is seeing some keyboard interaction. Sometimes the input will wait to "commit" the text until a space or period is entered.

Comment 7

[Peter Retzer (:pretzer)]

I just updated my release channel installation to FF23 and auto-completion works just fine for me there, right from the first character I type...  strange! 
The only difference between the two channels I can think of is the amount of history built up. Like I said I frequently clear all data on Nightly for testing purposes. Or maybe my Nightly profile is just broken in a weird way. Again, if I can do anything else to figure this out let me know!

Comment 8

[Aaron Train [:aaronmt]]

Please re-open if you see this again on 23+