Closed Bug 891833 Opened 13 years ago Closed 13 years ago

Identity box border is on the wrong side in RTL mode

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 25

People

(Reporter: mikedeboer, Assigned: dao)

References

(
URL
)

Details

(Keywords: regression)

Attachments

(3 files)

Identity Box in RTL mode issues
49.97 KB, image/png
Details
correctly adjust the background-position for RTL
2.38 KB, patch
mikedeboer
: review+
Details | Diff | Splinter Review
Identity box text padding
53.14 KB, image/png
Details
See screenshot. The Identity box in RTL mode is not in a good shape; the padding and background positioning (used for a fading border) need some love.
As far as I can dig through and discern the styles touched over the course of time, this bug might be as old as bug 667586 (http://hg.mozilla.org/mozilla-central/rev/af889781505c). But, I'll leave the relevant revision at http://hg.mozilla.org/mozilla-central/rev/3c5133764596.
I'm confused. Did this bug exist prior to bug 750106 for sites with extended validatation such as https://www.paypal.com/?
...extended validation...
(In reply to Dão Gottwald [:dao] from comment #2) > I'm confused. Did this bug exist prior to bug 750106 for sites with extended > validatation such as https://www.paypal.com/? I checked out and built (WITH clobber) http://hg.mozilla.org/mozilla-central/rev/f3c22357f4f7, the parent revision of bug 750106. The bug exists in that revision too for sites with extended validation.
Assignee: nobody → dao
Blocks: 667586
No longer blocks: 750106
Severity: critical → trivial
Component: Location Bar → Theme
OS: Mac OS X → All
Hardware: x86 → All
Summary: Identity box in URL bar styling issues in RTL mode → Identity box border is on the wrong side in RTL mode
Comment on attachment 773279 [details] [diff] [review] correctly adjust the background-position for RTL Review of attachment 773279 [details] [diff] [review]: ----------------------------------------------------------------- Wow, that was fast! :) It looks good, except that the padding of the text inside the identity box is not correct yet. Please see the attached screenshot.
Attachment #773279 - Flags: review?(mdeboer) → review-
Summary: Identity box border is on the wrong side in RTL mode → Identity box border is on the wrong side and adjust text padding in RTL mode
That would be a separate bug, not the one regressed by bug 667586.
Summary: Identity box border is on the wrong side and adjust text padding in RTL mode → Identity box border is on the wrong side in RTL mode
Status: NEW → ASSIGNED
Comment on attachment 773279 [details] [diff] [review] correctly adjust the background-position for RTL Review of attachment 773279 [details] [diff] [review]: ----------------------------------------------------------------- I'll file another bug for the text padding.
Attachment #773279 - Flags: review- → review+
Also, please don't forget to add the valid patch metadata when you commit to m-i.
https://hg.mozilla.org/mozilla-central/rev/c768c8c338c8
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: