891842 - Test failure 'Expression "{"anonid":"findbar-textbox"}" returned null. Anonymous == true' in testFindInPage.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Daniela Petrovici]

Happened today on Nigthly de and en-US on MAC OS 10.6.8 and MAC OS 10.8.4:
http://mozmill-ci.blargon7.com/#/functional/report/206c36485a655b168e74264237402757

NOTE:
This is due to another change to the find bar. Andreea has found the responsible changeset and will add it in the bug.

Comment 1

[Andreea Matei [:AndreeaMatei]]

This is the responsible changeset:
http://hg.mozilla.org/mozilla-central/rev/52f8868edc1d

Comment 2

[Daniela Petrovici]

It happens on Windows machines as well with latest Nightly. Cosmin will provide a skip patch shortly since just changing the lookup expression to include the new element does not work on Windows.

Comment 3

[Cosmin Malutan, [:cosmin-malutan]]

Attachment: patch_v1.0

A new element was introduced after findbar. Changing the Lookup expression works on Windows, I just had an issue with the testrun not taking the patch into account. Fixed it and it works properly now.

Reports:
MAC: http://mozmill-crowd.blargon7.com/#/functional/report/5aa1ca5e7015e3740d269dc947061e09
Linux: http://mozmill-crowd.blargon7.com/#/functional/report/5aa1ca5e7015e3740d269dc947070d9a
Windows: http://mozmill-crowd.blargon7.com/#/functional/report/5aa1ca5e7015e3740d269dc947070d9a

Comment 4

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 773313 [details] [diff] [review]
patch_v1.0

Review of attachment 773313 [details] [diff] [review]:
-----------------------------------------------------------------

I've landed this as it is to stop the failures today and not skip the test.
But please add a follow up to remove that trailing whitespace. Thanks

http://hg.mozilla.org/qa/mozmill-tests/rev/5916909ec30b (default)

Comment 5

[Cosmin Malutan, [:cosmin-malutan]]

Attachment: follow-up patch v1.0

Removed trailing whitespace as requested.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Andreea Matei [:AndreeaMatei] from comment #4)
> I've landed this as it is to stop the failures today and not skip the test.
> But please add a follow up to remove that trailing whitespace. Thanks

You could have fixed this with the landing. In the future I don't really want to see separate patches for white-space only changes landed afterward. That's disturbing and not necessary. Thanks.

Comment 7

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 773325 [details] [diff] [review]
follow-up patch v1.0

Review of attachment 773325 [details] [diff] [review]:
-----------------------------------------------------------------

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/c0bd1d65a881 (default)