Update empty string handling in named getters to spec changes

RESOLVED FIXED in mozilla32

Status

()

defect
RESOLVED FIXED
6 years ago
a month ago

People

(Reporter: Ms2ger, Assigned: bzbarsky)

Tracking

({dev-doc-needed})

Trunk
mozilla32
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Whiteboard: [need review]
Comment on attachment 8425855 [details] [diff] [review]
Named getters for HTMLCollection should never return anything for ""

Might be good to test passing undefined and null.
Though, undefined/null should just use the default handling there.
Attachment #8425855 - Flags: review?(bugs) → review+
Hi Boris, sorry had to backout this change in https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=919fcf9baa00 since one of this 2 csets caused test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=40160645&tree=Mozilla-Inbound on all platforms
https://hg.mozilla.org/mozilla-central/rev/582bd1b5934c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.