Closed
Bug 891952
Opened 11 years ago
Closed 11 years ago
Update empty string handling in named getters to spec changes
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: Ms2ger, Assigned: bzbarsky)
Details
(Keywords: dev-doc-needed)
Attachments
(1 file)
|
9.20 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8425855 -
Flags: review?(bugs)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [need review]
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8425855 [details] [diff] [review]
Named getters for HTMLCollection should never return anything for ""
Might be good to test passing undefined and null.
Though, undefined/null should just use the default handling there.
Attachment #8425855 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Flags: in-testsuite+
Whiteboard: [need review]
|
||
Comment 4•11 years ago
|
||
Hi Boris, sorry had to backout this change in https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=919fcf9baa00 since one of this 2 csets caused test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=40160645&tree=Mozilla-Inbound on all platforms
|
Reporter | |
Comment 5•11 years ago
|
||
It was the other one; relanded.
https://hg.mozilla.org/integration/mozilla-inbound/rev/582bd1b5934c
|
|
||
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•