Closed Bug 892185 Opened 6 years ago Closed 6 years ago

Ctrl+Shift+J/Cmd+Opt+J should toggle the console

Categories

(DevTools :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: fitzgen, Assigned: harth)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

If the devtools aren't open, it should open them and focus the console.

If the devtools are open, they should close.
Assignee: nobody → fayearthur
Summary: Ctrl+Shift+J/Cmd+Shift+J should toggle the devtools open/closed with focus on the console → Ctrl+Shift+J/Cmd+Opt+J should toggle the devtools open/closed with focus on the console
Attached patch console-key.patch (obsolete) — Splinter Review
This certainly does it.

Question is, do we want to change shortcuts on people? We could keep both shortcuts, but that seems unfair.
Attachment #783866 - Flags: review?(nfitzgerald)
Forgot to version the property name for l10n.
Attachment #783866 - Attachment is obsolete: true
Attachment #783866 - Flags: review?(nfitzgerald)
Attachment #783877 - Flags: review?(nfitzgerald)
Summary: Ctrl+Shift+J/Cmd+Opt+J should toggle the devtools open/closed with focus on the console → Ctrl+Shift+J/Cmd+Opt+J should toggle the console
Comment on attachment 783877 [details] [diff] [review]
keybinding with versioned property

Review of attachment 783877 [details] [diff] [review]:
-----------------------------------------------------------------

Hopefully we can just land all of these keyboard shortcuts at once and it is a clean break.
Attachment #783877 - Flags: review?(nfitzgerald) → review+
Status: NEW → ASSIGNED
Can someone land this? I can't check in on the wifi where I am. And update the commit message to be "Bug 892185 - Ctrl+Shift+J/Cmd+Opt+J should toggle the console; r=fitzgen"

Thanks!
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/fa280c8a55f0
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Backed out for mochitest-bc failures:

https://hg.mozilla.org/integration/fx-team/rev/b36e521b71cd
Whiteboard: [fixed-in-fx-team]
I am really embarrassed that I didn't run try on this obviously try-necessary patch. I'm sorry to waste everyone's time.

Fixed one of the test failures (browser_webconsole_bug_580001_closing_after_completion.js), try server here: https://tbpl.mozilla.org/?tree=Try&rev=e75b76a454ca

The other failure (browser_keybindings.js, on Linux and Windows) I'm worried is actually a platform issue.

I'm guessing that the shortcut Ctrl+Shift+J is actually taken on those platforms, can anyone confirm?
Okay, I have a feeling Ctrl+Shift+J opens the Browser Console on Windows and Linux. I don't know what to do here now.
(In reply to Heather Arthur [:harth] from comment #8)
> Okay, I have a feeling Ctrl+Shift+J opens the Browser Console on Windows and
> Linux. I don't know what to do here now.

Not a feeling. It is true. Also, Cmd Shift J opens downloads window on Mac, doesn't it ?
(In reply to Girish Sharma [:Optimizer] from comment #9)
> (In reply to Heather Arthur [:harth] from comment #8)
> > Okay, I have a feeling Ctrl+Shift+J opens the Browser Console on Windows and
> > Linux. I don't know what to do here now.
> 
> Not a feeling. It is true. Also, Cmd Shift J opens downloads window on Mac,
> doesn't it ?

Cmd+Shift+J opens the Browser Console on Mac too, but this bug is for Cmd+Opt+J.
(In reply to Girish Sharma [:Optimizer] from comment #9)
> (In reply to Heather Arthur [:harth] from comment #8)
> > Okay, I have a feeling Ctrl+Shift+J opens the Browser Console on Windows and
> > Linux. I don't know what to do here now.
> 
> Not a feeling. It is true. Also, Cmd Shift J opens downloads window on Mac,
> doesn't it ?

Cmd/Ctrl-J opens the Downloads window, I believe. No shift involved.
(In reply to Wes Kocher (:KWierso) from comment #11)
> (In reply to Girish Sharma [:Optimizer] from comment #9)
> > (In reply to Heather Arthur [:harth] from comment #8)
> > > Okay, I have a feeling Ctrl+Shift+J opens the Browser Console on Windows and
> > > Linux. I don't know what to do here now.
> > 
> > Not a feeling. It is true. Also, Cmd Shift J opens downloads window on Mac,
> > doesn't it ?
> 
> Cmd/Ctrl-J opens the Downloads window, I believe. No shift involved.

On Mac, the requirement of Shift is inverted, Cmd J opens Browser Console, Cmd Shift J opens Downloads Library :-/
Oops, disregard my above comment please. I am wrong to an infinity level :)
Guess we can't do this due to the Browser Console's shortcut on Win/Linux. Maybe we want to add J as an extra shortcut for Mac, but that seems to be hogging shortcuts.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.