892185 - Ctrl+Shift+J/Cmd+Opt+J should toggle the console

Status: RESOLVED WONTFIX

(DevTools :: General, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

If the devtools aren't open, it should open them and focus the console.

If the devtools are open, they should close.

Comment 1

[Heather Arthur [:harth]]

Attachment: console-key.patch

This certainly does it.

Question is, do we want to change shortcuts on people? We could keep both shortcuts, but that seems unfair.

Comment 2

[Heather Arthur [:harth]]

Attachment: keybinding with versioned property

Forgot to version the property name for l10n.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 783877 [details] [diff] [review]
keybinding with versioned property

Review of attachment 783877 [details] [diff] [review]:
-----------------------------------------------------------------

Hopefully we can just land all of these keyboard shortcuts at once and it is a clean break.

Comment 4

[Heather Arthur [:harth]]

Can someone land this? I can't check in on the wifi where I am. And update the commit message to be "Bug 892185 - Ctrl+Shift+J/Cmd+Opt+J should toggle the console; r=fitzgen"

Thanks!

Comment 5

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/fa280c8a55f0

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Backed out for mochitest-bc failures:

https://hg.mozilla.org/integration/fx-team/rev/b36e521b71cd

Comment 7

[Heather Arthur [:harth]]

I am really embarrassed that I didn't run try on this obviously try-necessary patch. I'm sorry to waste everyone's time.

Fixed one of the test failures (browser_webconsole_bug_580001_closing_after_completion.js), try server here: https://tbpl.mozilla.org/?tree=Try&rev=e75b76a454ca

The other failure (browser_keybindings.js, on Linux and Windows) I'm worried is actually a platform issue.

I'm guessing that the shortcut Ctrl+Shift+J is actually taken on those platforms, can anyone confirm?

Comment 8

[Heather Arthur [:harth]]

Okay, I have a feeling Ctrl+Shift+J opens the Browser Console on Windows and Linux. I don't know what to do here now.

Comment 9

[Girish Sharma [:Optimizer]]

(In reply to Heather Arthur [:harth] from comment #8)
> Okay, I have a feeling Ctrl+Shift+J opens the Browser Console on Windows and
> Linux. I don't know what to do here now.

Not a feeling. It is true. Also, Cmd Shift J opens downloads window on Mac, doesn't it ?

Comment 10

[Heather Arthur [:harth]]

(In reply to Girish Sharma [:Optimizer] from comment #9)
> (In reply to Heather Arthur [:harth] from comment #8)
> > Okay, I have a feeling Ctrl+Shift+J opens the Browser Console on Windows and
> > Linux. I don't know what to do here now.
> 
> Not a feeling. It is true. Also, Cmd Shift J opens downloads window on Mac,
> doesn't it ?

Cmd+Shift+J opens the Browser Console on Mac too, but this bug is for Cmd+Opt+J.

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Girish Sharma [:Optimizer] from comment #9)
> (In reply to Heather Arthur [:harth] from comment #8)
> > Okay, I have a feeling Ctrl+Shift+J opens the Browser Console on Windows and
> > Linux. I don't know what to do here now.
> 
> Not a feeling. It is true. Also, Cmd Shift J opens downloads window on Mac,
> doesn't it ?

Cmd/Ctrl-J opens the Downloads window, I believe. No shift involved.

Comment 12

[Girish Sharma [:Optimizer]]

(In reply to Wes Kocher (:KWierso) from comment #11)
> (In reply to Girish Sharma [:Optimizer] from comment #9)
> > (In reply to Heather Arthur [:harth] from comment #8)
> > > Okay, I have a feeling Ctrl+Shift+J opens the Browser Console on Windows and
> > > Linux. I don't know what to do here now.
> > 
> > Not a feeling. It is true. Also, Cmd Shift J opens downloads window on Mac,
> > doesn't it ?
> 
> Cmd/Ctrl-J opens the Downloads window, I believe. No shift involved.

On Mac, the requirement of Shift is inverted, Cmd J opens Browser Console, Cmd Shift J opens Downloads Library :-/

Comment 13

[Girish Sharma [:Optimizer]]

Oops, disregard my above comment please. I am wrong to an infinity level :)

Comment 14

[Heather Arthur [:harth]]

Guess we can't do this due to the Browser Console's shortcut on Win/Linux. Maybe we want to add J as an extra shortcut for Mac, but that seems to be hogging shortcuts.