892246 - Urlbar doesn't auto-show on google.com, about:healthreport on tablet

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

Attachment: Screenshot: stuck w/o urlbar on tablet in about:healthreport

Caveat: this may only be on the Asus Transformer 1, but I don't have any other tablets to test on.

The new mobile about:healthreport seems to have the default right size to make urlbar auto-show break. 

STR:
1. Go to about:healthreport (must be new mobile site - see screenshot)
2. Scroll down
3. Scroll up

Expected:
urlbar auto-shows

Actual:
Can't get urlbar to autoshow. Need to actually resize so scrolling is enabled again and urlbar shows.

This is probably something of an edge case, and probably also happens for certain webpages. (I actually just realized this happens for the "tablet" version of google.com as well.)

Comment 1

[Aaron Train [:aaronmt]]

Which versions are affected here? I bet you tested on Nightly, how is Beta/Aurora?

Comment 2

[Nick Alexander :nalexander [he/him]]

To provide technical context on about:healthreport: the xhtml has the viewport set and the content inside is in an iframe.  It's possible the scrolling is never "seen" by the actual page.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

I can also repro this on a 10.1" Galaxy Tab in landscape.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Also, this /might/ be fixed by my patches for bug 877602.

Comment 5

[Aaron Train [:aaronmt]]

Chenxia, can you reproduce on today's Nightly now given bug 877602 is fixed?

Comment 6

[Chenxia Liu [:liuche]]

This is still reproducible for me (google.com), with the 7/12 nightly build, and the aurora build I just downloaded. I also did a partial mobile/android build of m-i (which includes kats's patch) and was able to repro.

Comment 7

[Chris Lord [:cwiiis]]

So after the patch in bug 886576, I can't reproduce this, but I have another patch that will mitigate similar problems incoming.

Comment 8

[Chris Lord [:cwiiis]]

Attachment: Allow subdocument scrolling to reveal margins

Does what it says on the tin.

Comment 9

[Chris Lord [:cwiiis]]

Comment on attachment 775680 [details] [diff] [review]
Allow subdocument scrolling to reveal margins

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Scrolling in certain areas doesn't reveal/hide the toolbar
User impact if declined: The toolbar can end up hidden with few obvious ways of getting it back
Testing completed (on m-c, etc.): Tested locally
Risk to taking this patch (and alternatives if risky): Low risk, perhaps there could be situations where the dynamic toolbar is unexpectedly hidden or shown in response to user input (but I'd have thought it was always expected)
String or IDL/UUID changes made by this patch: None

Comment 10

[Chris Lord [:cwiiis]]

Pushed to m-c:

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7743ae9df87

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e7743ae9df87

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fd8d6e5c0dec
https://hg.mozilla.org/releases/mozilla-beta/rev/d82b7796df90

Comment 13

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 24.0a2(2013-07-24)
Device: Asus Transformer TF
OS: Android 4.0.3

Comment 14

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 23.0b10(2013-07-29)
Device: Asus Transformer TF
OS: Android 4.0.3