892259 - Create a host plugin API so we can have multiple different hosts (think firefox, b2g, device) without changing tests.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Comment 1

[Dylan Oliver [:doliver]]

A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/53204469

Comment 2

[Dylan Oliver [:doliver]]

Dylan Oliver deleted the linked story in Pivotal Tracker

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Do we have more details for this bug?

Comment 4

[James Lal [:lightsofapollo]]

Here is my proposal for the host api:

https://gist.github.com/lightsofapollo/6042626

The child would be responsible for invoking the host and then passing the port/etc.. metadata to the actual process running the tests.

Comment 5

[James Lal [:lightsofapollo]]

Attachment: https://github.com/mozilla-b2g/marionette-js-runner/pull/6

The PR for the b2g-desktop host should probably be reviewed/landed first- 95% of the "framework" code is in this PR but I omitted the final integration test until we land the b2g-desktop host. I will then integrate that with this code so we always a default host...

Comment 6

[Gareth Aye [:gaye] (back from PTO)]

So this looks good to me. I did have one question about adding getters for things like the child process and marionette port to the public api. What do you think?

Comment 7

[James Lal [:lightsofapollo]]

Port I agree on- child process is another story and should be an implementation detail of the host itself... Think about the case where we have a device there will be no process. The less we expose here the more portability we get I think.

Comment 8

[James Lal [:lightsofapollo]]

in master https://github.com/lightsofapollo/marionette-js-runner/commit/acc3f76e96aca36347c074833a88d5519b3ad9f8

Comment 9

[Dylan Oliver [:doliver]]

Dylan Oliver added a comment in Pivotal Tracker:   
   
.

Comment 10

[Dylan Oliver [:doliver]]

Dylan Oliver deleted the linked story in Pivotal Tracker

Comment 11

[Dylan Oliver [:doliver]]

Dylan Oliver changed story state to accepted in Pivotal Tracker