Closed Bug 892268 Opened 6 years ago Closed 6 years ago

Ctrl/Cmd+0/+/- should change the text size in all the devtools and the panel

Categories

(DevTools :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: fitzgen, Assigned: harth)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

A few of the tools support this now in certain panes, but we should have this baked in for everything and also change the size of the toolbar text too.
Assignee: nobody → fayearthur
Attached patch zoom.patchSplinter Review
This patch patch add Ctrl+/-/0 to the toolbox, and removes those bindings from the web console.

It also focuses a devtools tab when it's selected. Before you'd have to click on a text area to focus the toolbox (and thus couldn't use our tab switching or zooming shortcuts until then).

Try: https://tbpl.mozilla.org/?tree=Try&rev=f121bd778f93
Attachment #804083 - Flags: review?(mihai.sucan)
Attachment #804083 - Flags: review?(paul)
Attachment #804083 - Flags: review?(paul) → review?(dcamp)
Attachment #804083 - Flags: review?(dcamp) → review+
Comment on attachment 804083 [details] [diff] [review]
zoom.patch

Review of attachment 804083 [details] [diff] [review]:
-----------------------------------------------------------------

Whole-hearted r+! Just tested and it makes my day. *Very* glad to see this full zoom for the toolbox. Now everything is much more readable for me. Thank you Heather!

One concern: the removal of zoom support from the Web Console makes sense, but the Browser Console is not part of the toolbox yet. Can you please keep zoom in the Browser Console only? Until we have the Browser toolbox.
Attachment #804083 - Flags: review?(mihai.sucan) → review+
Mihai, can you give(In reply to Mihai Sucan [:msucan] from comment #2)
> One concern: the removal of zoom support from the Web Console makes sense,
> but the Browser Console is not part of the toolbox yet. Can you please keep
> zoom in the Browser Console only? Until we have the Browser toolbox.

Any quick code pointers on how to do that?
Flags: needinfo?(mihai.sucan)
(In reply to Heather Arthur [:harth] from comment #3)
> Mihai, can you give(In reply to Mihai Sucan [:msucan] from comment #2)
> > One concern: the removal of zoom support from the Web Console makes sense,
> > but the Browser Console is not part of the toolbox yet. Can you please keep
> > zoom in the Browser Console only? Until we have the Browser toolbox.
> 
> Any quick code pointers on how to do that?

Browser Console instances have a _browserConsole boolean flag set to true. In the command controller I suggest you return false for isCommandEnabled() and for supportsCommand(), when the flag is false. See how cmd_close works.
Flags: needinfo?(mihai.sucan)
(In reply to Mihai Sucan [:msucan] from comment #4)
> Browser Console instances have a _browserConsole boolean flag set to true.
> In the command controller I suggest you return false for isCommandEnabled()
> and for supportsCommand(), when the flag is false. See how cmd_close works.

Thanks for the tip. Unfortunately that makes it so the web console still swallows those keys but does nothing. Barring any breakthroughs soon I'll just add back the web console zoom and have that one be weird.
Heather: this is what I had in mind for the webconsole.js/xul changes. Like in the case of cmd_close: supportsCommand returns false, cmd_fullZoom commands are disabled by default in the xul file, and during init, if it is a browser console, we remove the 'disabled' attribute from the zoom commands.

(I started to make this patch by first reverting the changes to webconsole.jss/xul/dtd from your patch.)

Since your patch already landed, I am not sure how we should proceed. Should we make a patch that applies for fx-team or should we open a new bug?
https://hg.mozilla.org/mozilla-central/rev/e50ef9cabb1f
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Cmd and + and Cmd and - works for me in Mac OS X, but Cmd and 0 does nothing (i.e. doesn't restore it to the original size).
(In reply to Robert Nyman from comment #9)
> Cmd and + and Cmd and - works for me in Mac OS X, but Cmd and 0 does nothing
> (i.e. doesn't restore it to the original size).

Works for me. Make sure the devtools has focus by clicking on a tool tab. File a new bug about it.
Apparently it worked after a restart of Aurora. Thanks.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.