Closed Bug 892275 Opened 7 years ago Closed 6 years ago

F2 should make the selected node and its children editable as html

Categories

(DevTools :: Inspector, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 28

People

(Reporter: fitzgen, Assigned: bgrins)

References

(Blocks 1 open bug)

Details

(Whiteboard: [good first verify] )

Attachments

(1 file)

Should be able to select a node, press F2, and then edit the node and its children as HTML.
Depends on: 895561
Assignee: nobody → bgrinstead
Attached patch f2.patchSplinter Review
Adds ability to press F2 to edit selected node.  When editing, pressing F2 again acts as accel+enter (it will save changes if anything has changed, or close the editor if not).  Additionally, we now refocus the doc after editing has finished, so you can continue to use keyboard shortcuts on the selected node.  

I've also split up the outerHTML tests, since it was already causing an intermittent timeout and I was adding more to it.

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=5a079e25d6e7
Attachment #828696 - Flags: review?(mratcliffe)
Attachment #828696 - Flags: review?(mratcliffe) → review+
https://hg.mozilla.org/mozilla-central/rev/3e98116d9d40
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
Keywords: verifyme
Keywords: verifyme
Whiteboard: [good first verify]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.