F2 should make the selected node and its children editable as html

RESOLVED FIXED in Firefox 28

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: fitzgen, Assigned: bgrins)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 28
x86
Mac OS X
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first verify] )

Attachments

(1 attachment)

Should be able to select a node, press F2, and then edit the node and its children as HTML.
Depends on: 895561
(Assignee)

Updated

4 years ago
Assignee: nobody → bgrinstead
(Assignee)

Comment 1

4 years ago
Created attachment 828696 [details] [diff] [review]
f2.patch

Adds ability to press F2 to edit selected node.  When editing, pressing F2 again acts as accel+enter (it will save changes if anything has changed, or close the editor if not).  Additionally, we now refocus the doc after editing has finished, so you can continue to use keyboard shortcuts on the selected node.  

I've also split up the outerHTML tests, since it was already causing an intermittent timeout and I was adding more to it.

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=5a079e25d6e7
Attachment #828696 - Flags: review?(mratcliffe)
Attachment #828696 - Flags: review?(mratcliffe) → review+
https://hg.mozilla.org/mozilla-central/rev/3e98116d9d40
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28

Updated

4 years ago
Keywords: verifyme

Updated

4 years ago
Keywords: verifyme
Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.