892277 - Change stepping hotkeys

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

When paused in the debugger, pressing F8 or Cmd/Ctrl+/ should resume the debugger.

Comment 1

[Brandon Benvie [:benvie]]

F8 is currently occupied by stepIn/stepOut so those need to be changed first.

Comment 2

[Brandon Benvie [:benvie]]

Ok, since the four step controlling bugs are closely related and trying to break them into separate patches causes the others to bitrot, I'm combining them into one bug.

Comment 3

[Brandon Benvie [:benvie]]

Attachment: bug-892277.patch

This patch changes the following hotkeys:

* resume - F8 and accel+/
* step over - F10 and accel+'
* step in - F11 and accel+;
* step out - shift+F11 and shift+accel+;

Comment 4

[Brandon Benvie [:benvie]]

https://tbpl.mozilla.org/?tree=Try&rev=6395f66f257d

Comment 5

[Dave Camp (:dcamp)]

Comment on attachment 783886 [details] [diff] [review]
bug-892277.patch

Let's reassign review to someone that's awake.  I nominate the newest peer.

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 783886 [details] [diff] [review]
bug-892277.patch

Review of attachment 783886 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with following change:

You need to rename the existing localization entities or else it won't update or something. Is insane. So "debuggerUI.stepping.resume" -> "debuggerUI.steppingKeys.resume", or whatever but for all of the pre-existing entities.

Comment 7

[Brandon Benvie [:benvie]]

Attachment: bug-892277.patch

Addresses fitzgen's feedback by changing all the old ones to be named "*1".

Comment 8

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/268b0ef4df3b

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/268b0ef4df3b