Closed Bug 892285 Opened 11 years ago Closed 11 years ago

Only unlock gralloc surfaces if they were locked

Categories

(Core :: Graphics: Layers, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(1 file, 2 obsolete files)

I believe this is related to bug 871624.

On the Nexus 7/tegra, the gralloc module crashes if we attempt to unlock a gralloc buffer that wasn't locked in the first place.
Attachment #773726 - Flags: review?(bas)
Attachment #773726 - Flags: review?(bas) → review+
(In reply to Ed Morley [:edmorley UTC+1] from comment #2)
> Backed out for failures in invalidation/test-animated-image-layers.html:
> https://tbpl.mozilla.org/php/getParsedLog.php?id=25209997&tree=Birch
> 
> https://hg.mozilla.org/projects/birch/rev/401198006c84

Any idea if those regression could be linked to "black screen symptom" ?
This version makes the code a bit more careful about also clearing mSurfaceAsImage when mSurface is cleared.
Attachment #773726 - Attachment is obsolete: true
(In reply to Michael Wu [:mwu] from comment #4)
> Created attachment 775866 [details] [diff] [review]
> Only unlock gralloc surfaces if they were locked, v2
> 
> This version makes the code a bit more careful about also clearing
> mSurfaceAsImage when mSurface is cleared.

Seems that this change is outdated with current Gecko master :(
Blocks: b2g-nexuss
Unbitrotted.
Attachment #775866 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/8be52459f181
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: