892285 - Only unlock gralloc surfaces if they were locked

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Michael Wu [:mwu]]

Attachment: Only unlock gralloc surfaces if they were locked

I believe this is related to bug 871624.

On the Nexus 7/tegra, the gralloc module crashes if we attempt to unlock a gralloc buffer that wasn't locked in the first place.

Comment 1

[Michael Wu [:mwu]]

https://hg.mozilla.org/projects/birch/rev/512a1fd86008

Comment 2

[Ed Morley [:emorley]]

Backed out for failures in invalidation/test-animated-image-layers.html:
https://tbpl.mozilla.org/php/getParsedLog.php?id=25209997&tree=Birch

https://hg.mozilla.org/projects/birch/rev/401198006c84

Comment 3

[:gerard-majax]

(In reply to Ed Morley [:edmorley UTC+1] from comment #2)
> Backed out for failures in invalidation/test-animated-image-layers.html:
> https://tbpl.mozilla.org/php/getParsedLog.php?id=25209997&tree=Birch
> 
> https://hg.mozilla.org/projects/birch/rev/401198006c84

Any idea if those regression could be linked to "black screen symptom" ?

Comment 4

[Michael Wu [:mwu]]

Attachment: Only unlock gralloc surfaces if they were locked, v2

This version makes the code a bit more careful about also clearing mSurfaceAsImage when mSurface is cleared.

Comment 5

[:gerard-majax]

(In reply to Michael Wu [:mwu] from comment #4)
> Created attachment 775866 [details] [diff] [review]
> Only unlock gralloc surfaces if they were locked, v2
> 
> This version makes the code a bit more careful about also clearing
> mSurfaceAsImage when mSurface is cleared.

Seems that this change is outdated with current Gecko master :(

Comment 6

[Michael Wu [:mwu]]

Attachment: Only unlock gralloc surfaces if they were locked, v3

Unbitrotted.

Comment 7

[Michael Wu [:mwu]]

https://tbpl.mozilla.org/?tree=Try&rev=e43979b7b885

Comment 8

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/b2g-inbound/rev/8be52459f181

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8be52459f181