Unsupported relocation type when building Fennec for armv6 with elfhack

RESOLVED FIXED in Firefox 24

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla25
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox24 fixed, firefox25 fixed)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 773822 [details] [diff] [review]
Support R_ARM_JUMP24 relocations in elfhack

R_ARM_PLT32 and R_ARM_JUMP24 both use the same operation according to "ELF for the ARM® Architecture".
It turns out gcc 4.7 uses R_ARM_JUMP24 relocations when gcc 4.6 was using R_ARM_PLT32 (which according to the same document is deprecated, thus the change)
Attachment #773822 - Flags: review?(nfroyd)
(Assignee)

Updated

5 years ago
Blocks: 892355
Attachment #773822 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/20f7f733bef7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
(Assignee)

Comment 4

5 years ago
Created attachment 776031 [details] [diff] [review]
Support R_ARM_CALL relocations in elfhack

Some other toolchains are using R_ARM_CALL (the debian armel toolchain), which essentially is the same.
Attachment #776031 - Flags: review?(nfroyd)
Attachment #776031 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 6

5 years ago
Comment on attachment 773822 [details] [diff] [review]
Support R_ARM_JUMP24 relocations in elfhack

[Approval Request Comment]
Required for bug 892355.
Testing completed (on m-c, etc.): Landed on m-c some time ago.
Risk to taking this patch (and alternatives if risky): Low, and backout is trivial.
String or IDL/UUID changes made by this patch: None
Attachment #773822 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 7

5 years ago
Comment on attachment 776031 [details] [diff] [review]
Support R_ARM_CALL relocations in elfhack

[Approval Request Comment]
Required for bug 892355.
Testing completed (on m-c, etc.): Essentially the same as the other patch from this bug, but for a different variable.
Risk to taking this patch (and alternatives if risky): Low, and backout is trivial.
String or IDL/UUID changes made by this patch: None
Attachment #776031 - Flags: approval-mozilla-aurora?
Comment on attachment 773822 [details] [diff] [review]
Support R_ARM_JUMP24 relocations in elfhack

Approving given this is needed for bug 892355.

Glandium, can you please help keep an eye on fallout's in case a backout is needed here.
Attachment #773822 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

5 years ago
Attachment #776031 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
status-firefox24: --- → fixed
status-firefox25: --- → fixed
You need to log in before you can comment on or make changes to this bug.