892366 - Unsupported relocation type when building Fennec for armv6 with elfhack

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Support R_ARM_JUMP24 relocations in elfhack

R_ARM_PLT32 and R_ARM_JUMP24 both use the same operation according to "ELF for the ARM® Architecture".
It turns out gcc 4.7 uses R_ARM_JUMP24 relocations when gcc 4.6 was using R_ARM_PLT32 (which according to the same document is deprecated, thus the change)

Comment 2

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/20f7f733bef7

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/20f7f733bef7

Comment 4

[Mike Hommey [:glandium]]

Attachment: Support R_ARM_CALL relocations in elfhack

Some other toolchains are using R_ARM_CALL (the debian armel toolchain), which essentially is the same.

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1aceeed11478

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 773822 [details] [diff] [review]
Support R_ARM_JUMP24 relocations in elfhack

[Approval Request Comment]
Required for bug 892355.
Testing completed (on m-c, etc.): Landed on m-c some time ago.
Risk to taking this patch (and alternatives if risky): Low, and backout is trivial.
String or IDL/UUID changes made by this patch: None

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 776031 [details] [diff] [review]
Support R_ARM_CALL relocations in elfhack

[Approval Request Comment]
Required for bug 892355.
Testing completed (on m-c, etc.): Essentially the same as the other patch from this bug, but for a different variable.
Risk to taking this patch (and alternatives if risky): Low, and backout is trivial.
String or IDL/UUID changes made by this patch: None

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1aceeed11478

Comment 9

[bhavana bajaj [:bajaj]]

Comment on attachment 773822 [details] [diff] [review]
Support R_ARM_JUMP24 relocations in elfhack

Approving given this is needed for bug 892355.

Glandium, can you please help keep an eye on fallout's in case a backout is needed here.

Comment 10

[Mike Hommey [:glandium]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7443408ae235
https://hg.mozilla.org/releases/mozilla-aurora/rev/2ab705b1fb97