892384 - When switching to a tab with an open find bar, focus it

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

There's code in tabbrowser.xml to keep the global find bar focused when switching tabs, but it stopped working with the landing of bug 537013. I think we should simply replace it with focusing the tab-specific find bar when switching to a tab.

Comment 1

[Adam]

Attachment: Change code to set focus instead of check it

Also added a test.

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 774269 [details] [diff] [review]
Change code to set focus instead of check it

>+                // If the find bar is visible, focus it.
>+                if (gFindBarInitialized && !gFindBar.hidden) {
>+                  gFindBar._findField.focus();
>                   break;
>+                }

s/visible/open/

Thanks!

Comment 3

[Adam]

Attachment: Prepared for checkin

Pushed to try (atop the patch of bug 891638 because it isn't on m-c yet): https://tbpl.mozilla.org/?tree=Try&rev=8f57f4f9a9f8

Comment 4

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a46657d49e2

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9a46657d49e2

Comment 6

[Petruta Horea [:phorea], Desktop QA]

While testing for the pre-beta sign-off of the Find Bar Redesign feature, I tried to verify this bug with the latest Aurora (build ID: 20130903004001), and this works as expected on Win 7 32-bit, Mac OS X 10.7.5 and Ubuntu 13.04 32-bit.