892392 - [OTA][Data Migration][Bluetooth] Bluetooth function is turned off after update from v1.0.1 to v1.1.0

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Hubert Lu[:hlu] <[e-mail]>]

Attachment: logcat

Bluetooth function is turned off after update from v1.0.1 to v1.1.0

* Build Number (Both Gecko and Gaia)
Gaia:     680c72ccbd2d5045e590a6ba08de2aac6af71953
  B-D     2013-07-11 05:27:20
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/b64372810dd7
BuildID   20130710230201
Version   18.0


* Reproduce Steps
1. Flash device to v1.0.1 build from pvt
2. Change update URL to http://update.boot2gecko.org/inari/1.1.0/nightly/update.xml
3. Pair a BT device with phone device
4. Transfer one file to make sure phone pair with BT device and function works well.
5. Download and install gaia/gecko OTA update.
6. After auto-restart, go settings page to check if paired device information still exist.

* Actual results:
The Bluetooth function is turned off after update.

* * Expected results:
The Bluetooth function should not be turned off after update.

Comment 1

[Walter Chen[:ypwalter][:wachen]]

Hubert tested it in inari by askeing's special script and get the OTA.
please refer to TW-QA scripts repository for changing OTA url:
https://github.com/Mozilla-TWQA/B2G-flash-tool
change_OTA_URL.sh

I tested it in unagi in v1train.
I think no matter from v101 to v110 or from v110 to v110,
After ota, bt would be turned off.

Gina, Shawn, Eric,
Is this expected? Or, maybe it should be handled in other ways?

Comment 2

[Walter Chen[:ypwalter][:wachen]]

Just a side note.
20130710230201 buildID looks like pvt build.

Comment 3

[Eric Chou [:ericchou] [:echou]]

I can reproduce. I'll take a look.

Comment 4

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: execute BluetoothService::StartInternal() at startup

The root cause of this issue is that, everytime when B2G process restarts, BluetoothService::HandleStartupSettingsCheck() would be called. Then, if the Bluetooth status which has been set in mozSettings is true, the low-level Bluetooth firmware should be up as well. Follow the call path and it will run into ToggleBtTask::Run(), and you'll find out that 

  mEnabled == gBluetoothService->IsEnabledInternal()

is true, so StartInternal() won't be called.

In general cases, it's fine. However, if only b2g process restarts, StartInternal() has to be run because it's actually in charge of initialization of BluetoothService.

The patch fixes this problem via handling startup case individually.

Comment 5

[Gina Yeh [:gyeh] [:ginayeh]]

Comment on attachment 782466 [details] [diff] [review]
patch 1: v1: execute BluetoothService::StartInternal() at startup

Review of attachment 782466 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the late reply. Looks great to me.

Comment 6

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/b2g-inbound/rev/a043efd30cb1

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a043efd30cb1

Comment 8

[bhavana bajaj [:bajaj]]

Blocking as we want the user to be in the same state post update.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/54c3a5f55dd2

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/54c3a5f55dd2

Comment 11

[Walter Chen[:ypwalter][:wachen]]

Verified Fixed in today's pvt build

After updated:
Gaia:     5628b2ca37bea107d5da7f03959f70def2d55676
  B-D     2013-08-11 04:04:20
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/36bbc5943448
BuildID   20130811041203
Version   18.0

Comment 12

[Angela Hubenya]

Removing keyword tag based on comment 11.