Closed Bug 892413 Opened 6 years ago Closed 6 years ago

Followup fixes for bug 887605

Categories

(DevTools :: Netmonitor, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 25

People

(Reporter: vporof, Assigned: vporof)

Details

Attachments

(1 file)

No description provided.
Attached patch v1Splinter Review
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #773867 - Flags: review?(fayearthur)
Comment on attachment 773867 [details] [diff] [review]
v1

Review of attachment 773867 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/netmonitor/test/browser_net_copy_url.js
@@ +21,5 @@
> +      }, function onSuccess() {
> +        ok(true, "Clipboard contains the currently selected item's url.");
> +        cleanUp();
> +      }, function onFailure() {
> +        ok(false, "Copying the currently selected item's url was unsuccessful.");

waitForClipboard does the ok(true) and ok(false) for you, so this is redundant, unless you wanted to add those custom messages.
Attachment #773867 - Flags: review?(fayearthur) → review+
Whiteboard: [land-in-fx-team]
Priority: -- → P3
https://hg.mozilla.org/integration/fx-team/rev/11d1d03a247f
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/11d1d03a247f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.