Closed Bug 892425 Opened 7 years ago Closed 6 years ago
Defect - Layout in grid with bookmarks changes after navigation, also displays scrollbars
Odd quirky bug, STR: 1) have eight bookmarks saved 2) open metrofx note that bookmarks are laid out in two columns, four bookmarks each. 3) navigate to a site using touch 4) navigate back using the overlay back button result: bookmarks are now laid out in a single column, eight bookmarks with the lower bookmark slightly clipped by the nav bar. 5) move the mouse result: scrollbars on the bookmarks column reproduced on a Surface Pro.
Summary: Layout in grid with bookmarks changes after navigation, also displays scrollbars → Defect - Layout in grid with bookmarks changes after navigation, also displays scrollbars
Whiteboard: feature=defect c=tbd u=tbd p=0
The attached fixes the issue for me. Jimm can you confirm? I've left the outline on the bookmarks grid to make it more apparent. Also any feedback on the fix appreciated. Basically I leave space for a possible horizontal scrollbar.
Attachment #781159 - Flags: feedback?(mbrubeck) → feedback+
Comment on attachment 781159 [details] [diff] [review] Stabilize meta-section grid sizing fixes the problem for me. the grid layout remains unchanged between the nav and the nav back.
Attachment #781159 - Flags: feedback?(jmathies) → feedback+
Tightens up some of the richgrid sizing rules and logic - we now use the bound node as the reference bounding box if it has flex. By adding some margin to leave room for a horizontal scrollbar, the available space for the start grids doesn't change so we don't get grid rearranging as the precise/imprecise input value flips.
Attachment #781258 - Flags: review?(mbrubeck) → review+
Some merging, then: https://hg.mozilla.org/integration/mozilla-inbound/rev/aacf8f0ef017
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0 Build ID: 20130806104538 Built from http://hg.mozilla.org/mozilla-central/rev/1e381c91885d WFM Tested on windows 8 using latest nightly. Followed steps provided in comment0 and got expected result.
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 Build ID: 20130815030203 Built from http://hg.mozilla.org/mozilla-central/rev/a8daa428ccbc WFM Tested on windows 8 using latest nightly for iteration-12. I don't see any issue after using overlay back button.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.