892492 - Fix automation on AudioBufferSourceNode.playbackRate

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Comment 1

[Paul Adenot (:padenot)]

Attachment: patch

Comment 2

[Paul Adenot (:padenot)]

Comment on attachment 773953 [details] [diff] [review]
patch

This fixes wubwubwub and other testcases I had lying around. I'll write a test as soon as I have the AudioParam.value returning the actual value (which is close).

Comment 3

[(no longer active)]

Comment on attachment 773953 [details] [diff] [review]
patch

Review of attachment 773953 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, this is exactly what I was thinking about.  Can you please remove the code path to handle a null source in ConvertTimeToTickHelper::Convert?  (As this is the last consumer of that code, that should be fine.)  r=me with that.

Comment 4

[Paul Adenot (:padenot)]

ha, I must have forgot to qref, it was supposed to be in this patch. It was indeed the only consumer.

Comment 5

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/216b74874ef0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/216b74874ef0

Comment 7

[Alex Keybl [:akeybl]]

We'll take a fix in 24 on Aurora for this. Please nominate when you get the chance. Thanks!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7207a85189f1

Comment 9

[u279076]

Assuming no verification needed here. Please add the verifyme keyword and remove the [qa-] whiteboard tag to request verification.