89255 - Inconsistent prefs UI: "Manage CRLs" has no "Cancel"

Status: VERIFIED WONTFIX

(Core :: Security: PSM, enhancement, P3)

Description

[Mike Schiraldi]

As per mpt's comment at the end of 83206, i'm opening an RFE for this.

Every popup in the Prefs section has a button that will close it, be it Ok, 
Cancel, or Close, except the Manage CRLs button:

Prefs itself:            Ok, Cancel
All the "Choose File"s:  Open, Cancel
Languages->Add:          Ok, Cancel
Helper Apps->New Type:   Ok, Cancel
View Stored Cookies:     Ok, Cancel
Cookies->More Info:      Close       (because there's nothing to edit)
View Image Perms:        Ok, Cancel
View Stored Form Data:   Ok, Cancel
Forms->View Sites:       Ok, Cancel
View Stored Passwords:   Ok, Cancel
Edit Ciphers:            Ok, Cancel
Manage Certificates:     Close
Manage Security Devices: Ok
Manage CRLs:             <nothing>

I can abort my changes in most prefs popups by clicking cancel. So why are
Manage Certificates/Security Devices/CRLs different? Why shouldn't they have
"Ok" and "Cancel" buttons like everything else?

I don't know what mpt's guidelines say, but since your users won't have read 
them, it will look like a mistake to them and a lack of attention to detail.

Comment 1

[Keyser Sose]

Marking NEW.

Comment 2

[Peter Trudelle]

over to psm for triage.

Comment 3

[Mike Schiraldi]

Any news on this bug? Seems like a cinch to fix.

Comment 4

[Samir Gehani]

I guess this didn't get reassigned during triage.

Comment 5

[Mike Schiraldi]

Again, any news? 1.0 is around the corner, and the Prefs dialogs are still not
consistent. Compare "Manage CRLs" with "Manage Stored Passwords" -- either both
should have Okay / Cancel, or neither.

Comment 6

[Kai Engert [:KaiE:]]

Implementing this is difficult, because deleting is immediately reflected within
the security database. We don't delay the actions until you press OK, therefore
no OK is visible within that dialog.

The existence of a cancel button would make users believe they are able to
cancel what they were doing in that dialog. But they are not.

This is consistent with the behaviour of the certificate manager dialog, which
does not have a cancel dialog either.

Once upon a time we had a close button in certificate manager, to give users
something to click on if they don't know how to close it. But for some reason, I
don't understand why, there was a bug requesting to remove the the close button,
and it got removed.

Marking wontfix.

Comment 7

[Mike Schiraldi]

Opened #157712 as an RFE to make the changes in these boxes not take effect
immediately.

Comment 8

[John Unruh]

Verified.