892601 - Port over upstream native REST patch (bug 866927) to bmo/4.2

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: API, defect)

Description

[David Lawrence [:dkl]]

Port over upstream native REST patch (bug 866927) to bmo/4.2

Comment 1

[David Lawrence [:dkl]]

Pushed to bugzilla-dev.allizom.org for testing/feedback

Committing to: bzr+ssh://[e-mail]/bmo/4.2-dev
modified Bugzilla/Error.pm
modified template/en/default/global/user-error.html.tmpl
modified .htaccess
modified Bugzilla/Install/Requirements.pm
modified Bugzilla.pm
modified Bugzilla/CGI.pm
modified Bugzilla/WebService/Bug.pm
modified Bugzilla/WebService/Bugzilla.pm
added Bugzilla/WebService/Classification.pm
modified Bugzilla/WebService/Constants.pm
modified Bugzilla/WebService/Group.pm
modified Bugzilla/WebService/Product.pm
modified Bugzilla/WebService/User.pm
modified Bugzilla/WebService/Util.pm
added Bugzilla/WebService/Server/REST
added Bugzilla/WebService/Server/REST.pm
added Bugzilla/WebService/Server/REST/Resources
added Bugzilla/WebService/Server/REST/Resources/Bug.pm
added Bugzilla/WebService/Server/REST/Resources/Bugzilla.pm
added Bugzilla/WebService/Server/REST/Resources/Classification.pm
added Bugzilla/WebService/Server/REST/Resources/Group.pm
added Bugzilla/WebService/Server/REST/Resources/Product.pm
added Bugzilla/WebService/Server/REST/Resources/User.pm
modified Bugzilla/Constants.pm
added template/en/default/rest.html.tmpl
Committed revision 8509.

Comment 2

[David Lawrence [:dkl]]

Attachment: Patch to port bug 866927 (REST) to bmo/4.2 (v1)

Just posting the actual patch here if you want to review. Some changes had to be made to make it work with bmo/4.2 since the original was against trunk.

Also, how do you feel about me going ahead and committing to prod as I committed upstream now. Do we need some more sanity checking on bugzilla-dev.allizom.org?

dkl

Comment 3

[:glob ✱]

Comment on attachment 774902 [details] [diff] [review]
Patch to port bug 866927 (REST) to bmo/4.2 (v1)

Review of attachment 774902 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob, with .htaccess and Mailer.pm to be fixed on commit.

this is good to land on production now.

::: .htaccess
@@ +26,5 @@
>  
> +<IfModule mod_rewrite.c>
> +  RewriteEngine On
> +  RewriteRule ^rest/(.*)$ rest.cgi/$1 [NE]
> +</IfModule>

nit: as mod_rewrite is always enabled on bmo, you don't need the IfModule, just add the RewriteRule to the existing RewriteRule list.

::: Bugzilla/Mailer.pm
@@ +169,4 @@
>      # Allow for extensions to to drop the bugmail by clearing the 'to' header
>      return if $email->header('to') eq '';
>  
> +    return if $email->header('to') eq '';

we don't need this twice :)

Comment 4

[David Lawrence [:dkl]]

Committed. Further changes will be addressed as separate bugs.

Committing to: bzr+ssh://[e-mail]/bmo/4.2           
modified .htaccess
modified Bugzilla.pm                                                                  
added rest.cgi
modified Bugzilla/CGI.pm
modified Bugzilla/Constants.pm
modified Bugzilla/Error.pm
modified Bugzilla/WebService.pm
modified Bugzilla/Install/Requirements.pm
modified Bugzilla/WebService/Bug.pm                                               
modified Bugzilla/WebService/Bugzilla.pm
added Bugzilla/WebService/Classification.pm
modified Bugzilla/WebService/Constants.pm
modified Bugzilla/WebService/Group.pm
modified Bugzilla/WebService/Product.pm
modified Bugzilla/WebService/User.pm
modified Bugzilla/WebService/Util.pm
added Bugzilla/WebService/Server/REST
added Bugzilla/WebService/Server/REST.pm
added Bugzilla/WebService/Server/REST/Resources
added Bugzilla/WebService/Server/REST/Resources/Bug.pm                            
added Bugzilla/WebService/Server/REST/Resources/Bugzilla.pm
added Bugzilla/WebService/Server/REST/Resources/Classification.pm
added Bugzilla/WebService/Server/REST/Resources/Group.pm
added Bugzilla/WebService/Server/REST/Resources/Product.pm
added Bugzilla/WebService/Server/REST/Resources/User.pm
added template/en/default/rest.html.tmpl
modified template/en/default/global/user-error.html.tmpl                                  
modified template/en/default/setup/strings.txt.pl                                         
Committed revision 8873. 

dkl