892651 - selecting a range while filtering the device list causes devices to be selected outside of the filter

Status: RESOLVED FIXED

(Testing Graveyard :: Mozpool, defect)

Description

[Jake Watkins [:dividehex]]

I had tag a subset of devices with the comment '#badpanda' and filter for #badpanda in the lifeguard UI.  Then selected the range by select the first device, holding shift and then selecting the last device in the filtered list.  I then initiated a selftest and the selected subset.

But when i removed the filter tag, I saw that the entire list of devices was selected from the first to the last on the previously filtered list and the devices showed to ALL be pxebooting. :-{

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

I confirmed this in my test environment.  The range selection doesn't heed whether rows are visible.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug892651.patch

http://datatables.net/docs/DataTables/1.9.0/DataTable.models.oSettings.html
  aiDisplay is a list of the data indices of all visible table rows.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Bug 817762 closed the trees this morning, so I'd like to ship a new version of Mozpool Monday.  Mark, you can r? this by then, I can squeeze it in.

Comment 4

[Mark Côté [:mcote]]

Comment on attachment 774200 [details] [diff] [review]
bug892651.patch

Review of attachment 774200 [details] [diff] [review]:
-----------------------------------------------------------------

Looks and works great.  Just a tiny nit, and even that was in the original version.

::: mozpool/html/ui/js/views-tables.js
@@ +142,5 @@
> +            if (to_dispidx >= 0 && from_dispidx >= 0) {
> +                // sort the two indexes so we can iterate from one to the other
> +                if (from_dispidx > to_dispidx) {
> +                    var t;
> +                    t = from_dispidx;

Might as well combine this line and the previous.