892725 - Clean up browser.xul

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: General, defect, P2)

Description

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Following up from https://bugzilla.mozilla.org/show_bug.cgi?id=845468#c18

Browser.xul could be cleaned up to better respect an 80-character line limit and to be more consistent about when attributes in a tag go on one line versus multiple lines.

Comment 1

[Allison Naaktgeboren :ally]

I complain therefore I help fix.

Comment 2

[Allison Naaktgeboren :ally]

Attachment: cleanupBrowserXUL

..a good itch to scratch while sick.

I couldn't find anything in our style guide or in the main one about xul or xml. So I played with a couple. I settled on strict one attribute per line, I think proving Tim right. 

There are a couple places (like the very end of the file) where I let the 80 character line slide (that's one seriously one onclick! maybe it should have gone in a function... :/)

Comment 3

[Matt Brubeck (:mbrubeck)]

Comment on attachment 8372024 [details] [diff] [review]
cleanupBrowserXUL

Review of attachment 8372024 [details] [diff] [review]:
-----------------------------------------------------------------

so wrap
much
   indentation
cols=80
omg retro
   wow

r+

Comment 4

[Allison Naaktgeboren :ally]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/a51b70ee105f

r+ is in comment 3, confirmed on irc. Matt will update the flag properly. :)

Comment 5

[Allison Naaktgeboren :ally]

Documentation added https://wiki.mozilla.org/Firefox/Windows_8_Metro_Style_Guides#XUL_.2F_XML

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a51b70ee105f

Comment 7

[Manuela Muntean [Away]]

Could anyone please give guidance in order for the QA to verify this?

Comment 8

[Allison Naaktgeboren :ally]

I don't think this requires qa testing. There were no functional changes.