Following up from https://bugzilla.mozilla.org/show_bug.cgi?id=845468#c18 Browser.xul could be cleaned up to better respect an 80-character line limit and to be more consistent about when attributes in a tag go on one line versus multiple lines.
I complain therefore I help fix.
..a good itch to scratch while sick. I couldn't find anything in our style guide or in the main one about xul or xml. So I played with a couple. I settled on strict one attribute per line, I think proving Tim right. There are a couple places (like the very end of the file) where I let the 80 character line slide (that's one seriously one onclick! maybe it should have gone in a function... :/)
Attachment #8372024 - Flags: feedback?(mbrubeck)
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: [defect] p=0 → [defect] p=0 s=it-30c-29a-28b.1
Target Milestone: --- → Firefox 30
Comment on attachment 8372024 [details] [diff] [review] cleanupBrowserXUL Review of attachment 8372024 [details] [diff] [review]: ----------------------------------------------------------------- so wrap much indentation cols=80 omg retro wow r+
Attachment #8372024 - Flags: feedback?(mbrubeck) → feedback+
Whiteboard: [defect] p=0 s=it-30c-29a-28b.1 → [defect] p=1 s=it-30c-29a-28b.1
https://hg.mozilla.org/integration/mozilla-inbound/rev/a51b70ee105f r+ is in comment 3, confirmed on irc. Matt will update the flag properly. :)
Documentation added https://wiki.mozilla.org/Firefox/Windows_8_Metro_Style_Guides#XUL_.2F_XML
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [defect] p=1 s=it-30c-29a-28b.1 → p=1 s=it-30c-29a-28b.1 r=ff30
Could anyone please give guidance in order for the QA to verify this?
I don't think this requires qa testing. There were no functional changes.
Whiteboard: p=1 s=it-30c-29a-28b.1 r=ff30 → p=1 s=it-30c-29a-28b.1 r=ff30 [qa-]
You need to log in before you can comment on or make changes to this bug.