892741 - Add the ability to enable languages on -dev without enabling them in production

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, defect, P3)

Description

[Wil Clouser [:clouserw]]

We had this ability in AMO where we would allow a wider range of languages on the -dev server so localizers could preview the changes and make adjustments.  Then once they got 100% done with the localization we'd turn the language on in production.

This can be a completely separate list (our separate config files in zamboni would make this easy - not so in fireplace) or it can be some kind of a mashup where you can get to the language in prod if you type lang=xx but it won't be auto-detected.

There was some debate on the best way to do this with the API + frontend apps but I wanted to file this bug to get it on the radar.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

For Zamboni: just override https://github.com/mozilla/zamboni/blob/master/mkt/settings.py#L238-L240 in https://github.com/mozilla/zamboni/blob/master/sites/prod/settings_mkt.py

For Fireplace: we'll have to come up with a new solution for that.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

When we become a packaged app, we can allow the build process to accept a comma-separated list of locales for -dev à la:

    NAME='Dev' DOMAIN='marketplace-dev.allizom.org' LOCALES='en-US,pt-BR,es' make log

Comment 3

[Matt Basta [:basta]]

cvan got us most of the way there when he landed his data-settings update in fireplace.html. Next step is to update l10n.js to check for languages in that attribute.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/1dd81e3
https://github.com/mozilla/fireplace/commit/faa7861

Business, as usual.

Any languages specified in AMO_LANGUAGES

    https://github.com/mozilla/zamboni/blob/master/sites/dev/settings_mkt.py#L122-L127

get passed to the template that serves Fireplace. So whatever is changed the zamboni server from which Fireplace is served prod gets changed accordingly.

Let me know if you need anything else.

Comment 5

[Victor Carciu]

Can you please add some specific STRs to this bug or mark it as [qa-] ?