Closed
Bug 892799
Opened 11 years ago
Closed 11 years ago
If currentset is absent, don't need to move items around in legacy areas.
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: jaws, Assigned: jaws)
References
Details
(Whiteboard: [Australis:M8])
Attachments
(1 file)
1.23 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
When restoring the default positions, we do a lot of unnecessary moving around of toolbar items when we can just leave them alone.
This should help us on both startup and new window creations.
Baseline try push:
https://tbpl.mozilla.org/?tree=Try&rev=d0e5e0d84f47
Try push with patch applied:
https://tbpl.mozilla.org/?tree=Try&rev=924c31ed3f5b
Attachment #774365 -
Flags: review?(mconley)
Comment 1•11 years ago
|
||
Comment on attachment 774365 [details] [diff] [review]
Patch
Review of attachment 774365 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good!
Attachment #774365 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Whiteboard: [Australis:M8][fixed-in-ux]
Comment 3•11 years ago
|
||
Just so we don't lose track, this was backed out in https://hg.mozilla.org/projects/ux/rev/20526bcdf0a2, right?
Whiteboard: [Australis:M8][fixed-in-ux] → [Australis:M8]
Assignee | ||
Comment 4•11 years ago
|
||
Yes, it was. Thank you.
Assignee | ||
Comment 5•11 years ago
|
||
This didn't give us any perf wins, and it adds some more complexity to the code.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•