892841 - Break out of the toolbox children loop when we find the palette

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

In /browser/components/customizableui/content/toolbar.xml,

// Searching for the toolbox palette in the toolbar binding because
// toolbars are constructed first.
let toolbox = this.toolbox;
if (toolbox && !toolbox.palette) {
  for (let node of toolbox.children) {
    if (node.localName == "toolbarpalette") {
      // Hold on to the palette but remove it from the document.
      toolbox.palette = node;
      toolbox.removeChild(node);
    }
  }
}

We can break out of the loop once we find the palette. This would follow the same behavior that /toolkit/content/widgets/toolbar.xml already provides.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

As comment #0 mentions, this is not just a perf issue but also one of correctness if somehow multiple palettes exist.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Baseline,
https://tbpl.mozilla.org/?tree=Try&rev=395f9c40686d

With patch,
https://tbpl.mozilla.org/?tree=Try&rev=0aff825f4331

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/projects/ux/rev/6bfdb8e66c50

Comment 4

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/6bfdb8e66c50