Closed Bug 892937 Opened 6 years ago Closed 6 years ago

[responsive mode] default size should be the 1st preset

Categories

(DevTools :: Responsive Design Mode, defect)

Product:
DevTools
Component:
Responsive Design Mode
Platform:
x86
All
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 25

People

(Reporter: paul, Assigned: paul)

Details

Attachments

(1 file)

Patch v1
1.26 KB, patch
harth
: review+
Details | Diff | Splinter Review 
No description provided.
Assignee: nobody → paul
Attached patch Patch v1 — — Splinter Review
Attachment #774603 - Flags: review?(fayearthur)
Comment on attachment 774603 [details] [diff] [review]
Patch v1

Review of attachment 774603 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/responsivedesign/responsivedesign.jsm
@@ +145,5 @@
>  
>      this.customPreset.width = bbox.width - 40; // horizontal padding of the container
>      this.customPreset.height = bbox.height - 80; // vertical padding + toolbar height
>  
> +    this.currentPresetKey = this.presets[1].key; // most common preset

r=me as long as you meant to say 1 instead of 0 (=
Attachment #774603 - Flags: review?(fayearthur) → review+
(In reply to Heather Arthur [:harth] from comment #2)
> r=me as long as you meant to say 1 instead of 0 (=

I did. (0 is custom preset).
Whiteboard: [land-in-fx-team]
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/131854eced28
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.