Closed
Bug 892937
Opened 12 years ago
Closed 12 years ago
[responsive mode] default size should be the 1st preset
Categories
(DevTools :: Responsive Design Mode, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 25
People
(Reporter: paul, Assigned: paul)
Details
Attachments
(1 file)
1.26 KB,
patch
|
harth
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → paul
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #774603 -
Flags: review?(fayearthur)
Comment 2•12 years ago
|
||
Comment on attachment 774603 [details] [diff] [review]
Patch v1
Review of attachment 774603 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/devtools/responsivedesign/responsivedesign.jsm
@@ +145,5 @@
>
> this.customPreset.width = bbox.width - 40; // horizontal padding of the container
> this.customPreset.height = bbox.height - 80; // vertical padding + toolbar height
>
> + this.currentPresetKey = this.presets[1].key; // most common preset
r=me as long as you meant to say 1 instead of 0 (=
Attachment #774603 -
Flags: review?(fayearthur) → review+
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to Heather Arthur [:harth] from comment #2)
> r=me as long as you meant to say 1 instead of 0 (=
I did. (0 is custom preset).
Whiteboard: [land-in-fx-team]
Assignee | ||
Comment 4•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•