892977 - cfx run behaves different cfx xpi: cfx run includes third-party data/ directories, cfx xpi does not

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect)

Description

[Rob Wu [:robwu]]

Attachment: firefox-addon.zip

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:22.0) Gecko/20100101 Firefox/22.0 (Beta/Release)
Build ID: 20130625173050

Steps to reproduce:

Using `cfx xpi`, build an addon that depends on a third-party Jetpack module which has files in its data directory.

1. Create a Firefox add-on which depends on a third-party module (see attachment, firefox-addon.zip).
2. Run cfx xpi
3. Install the output xpi file (firefox-addon.xpi, also included in the zip file in the attachment) in Firefox

Tested using
- Firefox 22.0
- Add-on SDK 1.14 (39467a307f58b63c1907c8d383e48475c98b0624)


Actual results:

The addon does not function correctly, because the contents of the data directory of the third-party module is not included in the output xpi file.


Expected results:

The contents of the data/ directories of all third-party modules should have been included in the xpi file.

This works fine in cfx run/cfx test, so it's specific to `cfx xpi`.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

P1 to at least find out what's happening.

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

In bug 915376 we will drop our traditional third-party packages support in favor of npm style 3rd party packages, so even if this bug is real I don't think that we should bother fixing it at this point.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

http://work.erikvold.com/jetpack/2014/01/03/jetpack-in-the-future.html