892979 - Clicking on the markup view scrolls the view in a weird way

Status: RESOLVED WORKSFORME

(DevTools :: Inspector, defect, P2)

Description

[Paul Rouget [:paul]]

We call scrollIntoViewIfNeeded 3 times after the user clicked on a node. 1st time with centered=false (good), and 2 times with centered=true (bad).

Comment 1

[Paul Rouget [:paul]]

We should not scroll at all if the new selection comes from a mouse event. It's very perturbing to see the markup jumping right under the cursor.

Comment 2

[Paul Rouget [:paul]]

This is even more true in Gaia apps where the toolbox is on the side (narrow UI) and where there are long attributes with data urls.

Two examples:

- we see the bottom of a very long attribute. We click on it, the markup view scrolls up.
- we only see the end of a line, we click on an attribute to edit it, the markup view scrolls left.

In these 2 examples, the user wants to select something, and once selected, the newly selected element disappears due to the scroll.

Comment 3

[Paul Rouget [:paul]]

I won't be working on that anytime soon. But I'd be very happy if someone could take over :)

Comment 4

[Brian Grinstead [:bgrins]]

I bet this is the same thing I was seeing on point 3 in this comment: https://bugzilla.mozilla.org/show_bug.cgi?id=931191#c4.  It is quite dramatic if you open up a large inplace editor (seems to scroll everything out of view).  I agree that we should remove any scolling that happens as a result of clicking a node.

Comment 5

[Brian Grinstead [:bgrins]]

I don't think this is an issue anymore when switching nodes with the mouse, but there is code and a comment that indicates that maybe it should still be? http://dxr.mozilla.org/mozilla-central/source/browser/devtools/markupview/markup-view.js#724-725