take locales into account for firefox/update redirect

RESOLVED FIXED

Status

www.mozilla.org
Bedrock
P3
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: pascalc, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kb=1049857] )

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
This bedrock page didn't exist in the php codebase and was therefore not localized:
https://www.mozilla.org/en-US/firefox/update/

Even though I know this page is meant to be soon deprecated, it is currently popping up for users updating from older version of Firefox and the download box there is for en-US. We have localizers working on this page so at least for the bigger locales and locales that want to translate this page, I'd like the current redirect in bedrock to also take locales into account as there is no localized fallback for that page, not just en-US.

I am going to make a pull request for that.

Comment 2

5 years ago
Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/010175bb728f86c859971dd8e9614e599111b77a
Bug 893006 - change the rewrite rule for firefox/update to take locales into account if we have a translation
Created attachment 775759 [details]
screenshot

part of the text in clipped in IE7 and not shown at all in Firefox see attached screenshot
Depends on: 894074

Comment 4

5 years ago
Pascalc: can you confirm what locales are complete and activated? Without those activated locales, won't this fall back to en-US.

Comment 5

5 years ago
Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/0760ec64a7b8bf430a5aa13602c37a3501488100
Revert "Bug 893006 - change the rewrite rule for firefox/update to take locales into account if we have a translation"

This reverts commit 010175bb728f86c859971dd8e9614e599111b77a.

Updated

5 years ago
No longer depends on: 894074

Updated

5 years ago
Depends on: 869937

Updated

5 years ago
No longer depends on: 869937

Comment 6

5 years ago
Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/cede206ee39f031e501b021f57249ce2fe675e2c
Undo "Revert "Bug 893006 - change the rewrite rule for firefox/update to take locales into account if we have a translation""

This reverts commit 0760ec64a7b8bf430a5aa13602c37a3501488100.
Right now we have these locales ready: csb, de, el, es-AR, es-ES, eu, it, ko, ru, sk, sv-SE, zh-TW. Right now they're not enabled yet.
(Reporter)

Comment 8

5 years ago
(In reply to raymond [:retornam] from comment #3)
> Created attachment 775759 [details]
> screenshot
> 
> part of the text in clipped in IE7 and not shown at all in Firefox see
> attached screenshot

This is Tabzilla, not relatef to this bug.
(Reporter)

Comment 9

5 years ago
(In reply to Chris More [:cmore] from comment #4)
> Pascalc: can you confirm what locales are complete and activated? Without
> those activated locales, won't this fall back to en-US.

This is currently falling back to en-US, my patch was meant to allow us to push translations on production. Currently if we push translations on production, they are not taken into account because everything is redirected to en-US. See flod's comment for the list of locales we could push if we were not hitting this redirect to en-US.
(In reply to Pascal Chevrel:pascalc from comment #8)
> (In reply to raymond [:retornam] from comment #3)
> > Created attachment 775759 [details]
> > screenshot
> > 
> > part of the text in clipped in IE7 and not shown at all in Firefox see
> > attached screenshot
> 
> This is Tabzilla, not relatef to this bug.

Ignore this comment it was meant for another bug.
Priority: -- → P3
Whiteboard: [kb=1049857]

Updated

5 years ago
Blocks: 879544
Closing as per Comment 6.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.