893221 - Crash using OMTC and Windows 7

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

On the electrolysis branch, I'm getting a startup crash because LayerManagerComposite::Initialize() is returning false. In gfxWindowsPlatform.cpp, we request D3D_FEATURE_LEVEL_11_1 from d3d11CreateDevice(). According to MSDN, requesting this feature if DirectX 11.1 is not present will automatically return E_INVALIDARG, and DirectX 11.1 is Windows 8 only.

Would it be okay to just re-request a device with a fallback feature list, or should we check the Windows version before requesting 11.1?

Comment 1

[Jim Mathies [:jimm]]

Widget exports WinUtils for easy version checking, FWIW - 

http://mxr.mozilla.org/mozilla-central/source/widget/windows/WinUtils.h#43

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

Thanks - It turned out there was something similar right in the file so I just used that.

Comment 3

[Nick Cameron [:nrc]]

Comment on attachment 777443 [details] [diff] [review]
fix

Review of attachment 777443 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxWindowsPlatform.cpp
@@ +1464,5 @@
>    }
>  
> +  nsTArray<D3D_FEATURE_LEVEL> featureLevels;
> +  if (gfxWindowsPlatform::WindowsOSVersion() >= gfxWindowsPlatform::kWindows8)
> +    featureLevels.AppendElement(D3D_FEATURE_LEVEL_11_1);

Will this enum value be declared on Win <8? Or will we get a compile error for undeclared identifier?

Nit: {} please

Comment 4

[Jim Mathies [:jimm]]

You might consider ditching gfxWindowsPlatform::WindowsOSVersion all together and use WinUtils::WindownVersion() -

http://mxr.mozilla.org/mozilla-central/source/widget/windows/WinUtils.h#43

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

Yeah it will be declared.

https://hg.mozilla.org/integration/mozilla-inbound/rev/11d4b5839cd5

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/11d4b5839cd5