Closed Bug 893316 Opened 10 years ago Closed 10 years ago

Http.jsm doesn't listen to method option parameter

Categories

(Toolkit :: General, defect)

Product:
Toolkit
Component:
General
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla25

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(2 files)

Patch v1
1.07 KB, patch
mossop
: review+
Details | Diff | Splinter Review
Regression test
3.90 KB, patch
mossop
: review+
Details | Diff | Splinter Review 
Thunderbird's cloudfile tests are failing since bug 884319 landed because Http.jsm has a tiny bug in it - it doesn't pay attention to the method that the caller passes in. So it sticks to its defaults.

Working on a patch.
Attached patch Patch v1 — — Splinter Review 
Lemme whip up a test real quick.
Attached patch Regression test — — Splinter Review 
Spot the nerdy comp-sci joke!
Attachment #775086 - Flags: review?(dtownsend+bugmail)
Attachment #775087 - Flags: review?(dtownsend+bugmail)
(In reply to Mike Conley (:mconley) from comment #0)
> Thunderbird's cloudfile tests are failing since bug 884319 landed because
> Http.jsm has a tiny bug in it - it doesn't pay attention to the method that
> the caller passes in. So it sticks to its defaults.
> 
> Working on a patch.

Oh, doh. That's a very silly bug, sorry about that. Not that I can actually r+ this, but the change looks fine to me. Thanks for looking as this Mike.
Attachment #775086 - Flags: review?(dtownsend+bugmail) → review+
Attachment #775087 - Flags: review?(dtownsend+bugmail) → review+
You need to log in before you can comment on or make changes to this bug.