893324 - "Assertion failure: mCleanedUp" quitting during alert, with showModalDialog

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Attachment: testcase

1. Set:
     user_pref("dom.disable_open_during_load", false);
2. Load the testcase
3. While the alert is still up, press Cmd+Q

Assertion failure: mCleanedUp, at dom/base/nsGlobalWindow.cpp:1258

Based on the stack trace, I suspect bug 789919 (snow-white).

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Jesse Ruderman]

> Based on the stack trace, I suspect bug 789919 (snow-white).

Except the fuzzer found it on July 8, before snow-white landed.  So maybe bug 860941?

Comment 3

[Andrew McCreight [:mccr8]]

Stacks that involve the destructor of any CCed thing are now going to involve SnowWhiteKiller.

Comment 4

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=7aaf5bcb2ecf

Comment 5

[Bobby Holley (:bholley)]

Attachment: Invoke CleanUp synchronously and unconditionally for modal dialog windows. v1

Historically, we've had a bunch of complicated machinery to delay the call to
CleanUp() for modal dialogs, since we needed to harvest the return value after
the window closed. But in the current world we don't actually null out
mReturnValue in CleanUp() at all, which presumably happened sometime around the
time mReturnValue became cycle-collected. So this stuff can just go away. \o/

That simplification is righteous in itself. But it also fixes the bug here as-
filed. When the user quits while a modal dialog is currently being displayed,
a failure code ends up bubbling up through windowWatcher to the OpenInternal call
in nsGlobalWindow::ShowModalDialog, which means that we're unable to do our
delayed CleanUp() call for the outer modal window. At first it seemed like a hard
problem to solve, but with the above it becomes trivial.

Comment 6

[Jesse Ruderman]

Is this simplification expected to fix any of my other recent showModalDialog bugs? (Bug 893340, bug 897399, bug 897867)

Comment 7

[Bobby Holley (:bholley)]

(In reply to Jesse Ruderman from comment #6)
> Is this simplification expected to fix any of my other recent
> showModalDialog bugs? (Bug 893340, bug 897399, bug 897867)

From a cursory glance at those three bugs, I would guess 'no'.

Comment 8

[Johnny Stenback (:jst)]

Comment on attachment 781378 [details] [diff] [review]
Invoke CleanUp synchronously and unconditionally for modal dialog windows. v1

Nice!

Comment 9

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a685f0150c6c

Comment 10

[Bobby Holley (:bholley)]

Oh hm, looks like what appeared to be an intermittent failure on the try push occurred again when I retriggered it (test_bug893537.html). I'm still pretty sure this patch isn't the culprit, since this only affects modal dialogs, and we don't appear to be invoking showModalDialog anywhere in that test directory.

If I'd noticed this before pushing, I would have done another try push on a new base rev. But for now let's just hope for the best.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a685f0150c6c