Closed Bug 893424 Opened 7 years ago Closed 7 years ago
Window's broken _host Changed logic
See bug 889428 comment 5.
The only potential issue I can see with this is that checking gBrowser.currentURI in every onSecurityChange call surely is more expensive than checking this._hostChanged was, but probably not to an extent that we need to worry about it. As long as talos doesn't complain...
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #775194 - Flags: review?(jaws)
Attachment #775194 - Flags: review?(jaws) → review+
(In reply to Jared Wein [:jaws] from bug 889428 comment #5) > In the case where this is failing, onSecurityChange is being called before > onLocationChange, but there is an implicit ordering dependency between these > functions since onLocationChange resets this._hostChanged and > onSecurityChange checks this value. Seems like maybe we should have a PSM bug on file to sort out whether this should be happening, given that these notifications exist solely to address UI needs this seems unexpected.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
You need to log in before you can comment on or make changes to this bug.