Closed
Bug 893501
Opened 11 years ago
Closed 11 years ago
Crash getting navigator.mozNotification from a stale navigator object
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: jruderman, Assigned: baku)
References
Details
(Keywords: crash, testcase)
Crash Data
Attachments
(3 files, 1 obsolete file)
426 bytes,
text/html
|
Details | |
22.26 KB,
text/plain
|
Details | |
1.09 KB,
patch
|
Details | Diff | Splinter Review |
With: user_pref("notification.feature.enabled", true); The testcase causes a crash [@ mozilla::dom::Navigator::GetMozNotification] bp-1812654a-cd26-41df-b760-d805d2130714
Reporter | ||
Comment 1•11 years ago
|
||
Comment 2•11 years ago
|
||
On Windows: bp-093320fc-3bf2-4296-a2a8-d10db2130714.
Crash Signature: [@ mozilla::dom::Navigator::GetMozNotification(nsISupports**)]
[@ nsINode::NodePrincipal() ]
OS: Mac OS X → All
Hardware: x86_64 → All
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #776371 -
Flags: review?(bzbarsky)
Comment 5•11 years ago
|
||
Comment on attachment 776371 [details] [diff] [review] patch r=me
Attachment #776371 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 6•11 years ago
|
||
(In reply to Boris Zbarsky (:bz) from comment #3) > William, is this enabled by default anywhere? fennec
Flags: needinfo?(wchen)
Comment 8•11 years ago
|
||
Backed out for Android mochitest-7 orange. https://hg.mozilla.org/integration/mozilla-inbound/rev/f3169dd4bfb6 https://tbpl.mozilla.org/php/getParsedLog.php?id=25338785&tree=Mozilla-Inbound
Comment 9•11 years ago
|
||
Looks like robocop-2 as well. https://tbpl.mozilla.org/php/getParsedLog.php?id=25340542&tree=Mozilla-Inbound
Comment 10•11 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #9) > Looks like robocop-2 as well. > https://tbpl.mozilla.org/php/getParsedLog.php?id=25340542&tree=Mozilla- > Inbound This wasn't yours, just the mochitest-7.
Assignee | ||
Comment 11•11 years ago
|
||
This is the patch without the test. The test will be submitted in a follow up.
Attachment #776371 -
Attachment is obsolete: true
Assignee | ||
Comment 12•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e37652a7c199
Comment 13•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e37652a7c199
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+ → in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•