Crash getting navigator.mozNotification from a stale navigator object

RESOLVED FIXED in mozilla25

Status

()

Core
DOM
--
critical
RESOLVED FIXED
5 years ago
4 months ago

People

(Reporter: Jesse Ruderman, Assigned: baku)

Tracking

(Blocks: 2 bugs, {crash, testcase})

Trunk
mozilla25
crash, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Created attachment 775276 [details]
testcase (crashes Firefox when loaded)

With:
  user_pref("notification.feature.enabled", true);

The testcase causes a crash [@ mozilla::dom::Navigator::GetMozNotification]

bp-1812654a-cd26-41df-b760-d805d2130714
(Reporter)

Comment 1

5 years ago
Created attachment 775277 [details]
debug stack

Comment 2

5 years ago
On Windows: bp-093320fc-3bf2-4296-a2a8-d10db2130714.
Crash Signature: [@ mozilla::dom::Navigator::GetMozNotification(nsISupports**)] [@ nsINode::NodePrincipal() ]
OS: Mac OS X → All
Hardware: x86_64 → All
William, is this enabled by default anywhere?
Flags: needinfo?(wchen)
(Assignee)

Comment 4

5 years ago
Created attachment 776371 [details] [diff] [review]
patch
Attachment #776371 - Flags: review?(bzbarsky)
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(In reply to Boris Zbarsky (:bz) from comment #3)
> William, is this enabled by default anywhere?

fennec
Flags: needinfo?(wchen)
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c89df01905f
Assignee: nobody → amarchesini
Flags: in-testsuite+
Keywords: checkin-needed
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #9)
> Looks like robocop-2 as well.
> https://tbpl.mozilla.org/php/getParsedLog.php?id=25340542&tree=Mozilla-
> Inbound

This wasn't yours, just the mochitest-7.
(Assignee)

Comment 11

5 years ago
Created attachment 779170 [details] [diff] [review]
crash2.patch

This is the patch without the test. The test will be submitted in a follow up.
Attachment #776371 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/e37652a7c199
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+ → in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.