893532 - eBay France search engine obsolete

Status: RESOLVED FIXED

(Mozilla Localizations :: fr / French, defect)

Description

[Stephane Calonnec]

Attachment: eBay-france.xml

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:22.0) Gecko/20100101 Firefox/22.0 (Beta/Release)
Build ID: 20130618035212

Steps to reproduce:

Do any fast search on included eBay France search engine.


Actual results:

Search is redirect to "Petites annonces" section, which was closed by eBay - Search engine then is unusable.


Expected results:

Should return a search on the whole French eBay website, not on closed Petites Annonces section.

Comment 1

[Stephane Calonnec]

Attachment: The patched XML file for a correct search.

This XML file is the corrected version to make the search engine working again.

Comment 2

[Théo Chevalier]

Oops, thanks for pointing that out!

Comment 3

[Théo Chevalier]

Attachment: Fix desktop ebay search

Approval request for landing those patch on Nightly, Aurora & Beta

Comment 4

[Théo Chevalier]

Attachment: Fix ebay favicon on mobile

While we are at it, we should update this favicon :)

Comment 5

[Stephane Calonnec]

I put #775434 to the test.

- Search works fine, url is like : 
http://www.ebay.fr/sch/i.html?_nkw=test&_armrs=1&_from=&_ipg=

On the original file I uploaded, URL is like :
http://www.ebay.fr/sch/i.html?_nkw=test&clk_rvr_id=500585950190

I don't know the use of variables _armrs, _from and _ipg. Are they useful ?

- Favicon updated fine

- (!) On-typing search suggestions not implemented.

I don't know if it's normal, but there is "+" and "-" at the begininng of the <Image> tags.

Comment 6

[Théo Chevalier]

(In reply to Stephane Calonnec from comment #5)
> I put #775434 to the test.
> 
> - Search works fine, url is like : 
> http://www.ebay.fr/sch/i.html?_nkw=test&_armrs=1&_from=&_ipg=
> 
> On the original file I uploaded, URL is like :
> http://www.ebay.fr/sch/i.html?_nkw=test&clk_rvr_id=500585950190
> 
> I don't know the use of variables _armrs, _from and _ipg. Are they useful ?

I don't think so. On the old query, we only use _nkw for the search term, I don't see any reason to change that.
Furthermore, other teams are using the same template, for instance, the en-GB file:
http://mxr.mozilla.org/l10n-central/source/en-GB/browser/searchplugins/eBay-en-GB.xml

> 
> - Favicon updated fine
Great

> 
> - (!) On-typing search suggestions not implemented.
I think this is out of the scope of this bug :)

> 
> I don't know if it's normal, but there is "+" and "-" at the begininng of
> the <Image> tags.

Yes, I transformed your file into a "patch", this is what we will send to the Firefox codebase — a file showing the differences between current version of the file and your modifications.
+ is for added lines, - for removed lines
(but thanks for the updated file!)
I you want to know more: https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F


Milos, I checked over the l10n repository, we were the only locale using "allitems?_nkw"

I just noticed I missed the ebay files for Thunderbird & SeaMonkey

Comment 7

[Théo Chevalier]

Attachment: Update searchplugins for mobile/suite/mail

I think all favicons / query strings are up-to-date this time.

Milos, is that wanted having   <Param name="tag" value="firefox-fr-21"/> into mail/searchplugins/amazon-france.xml ? I guess it is used to track queries, but at first glance it seems wrong :)

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 775430 [details] [diff] [review]
Fix desktop ebay search

Review of attachment 775430 [details] [diff] [review]:
-----------------------------------------------------------------

this one looks good to me.

Comment 9

[Axel Hecht [:Pike]]

Comment on attachment 775541 [details] [diff] [review]
Update searchplugins for mobile/suite/mail

Review of attachment 775541 [details] [diff] [review]:
-----------------------------------------------------------------

r-, for most of this we're not the right reviewers, and for the mobile plugin, that should be a 32x32 image. Make sure that the data uri doesn't include % escaped characters, too.

Comment 10

[Théo Chevalier]

Attachment: part 3, update ebay searchplugin for mobile

Hey Francesco, could you review this one please?
I couldn't find any 32x32px image file on existing searchplugins, so I created a new one, see attached image (based on Wikipedia 32x32 + eBay svg logo).

Comment 11

[Théo Chevalier]

Attachment: part 2, update searchplugins for suite/mail

Justin, I hope you are the good reviewer for this patch

I fixed eBay searchplugin for Thunderbird with the same patch that the Firefox one (http://hg.mozilla.org/releases/l10n/mozilla-beta/fr/rev/c319b36101f2).
I also updated several outdated favicons.

Comment 12

[Théo Chevalier]

Attachment: eBay favicon, 32x32

Comment 13

[Francesco Lodolo [:flod]]

Comment on attachment 787870 [details] [diff] [review]
part 3, update ebay searchplugin for mobile

Patch applies cleanly, favicon is there and the searchplugin works as expected.
Not really sure I'm entitled to do this kind of reviews yet, so flagging Axel.

Comment 14

[Justin Wood (:Callek)]

Comment on attachment 787872 [details] [diff] [review]
part 2, update searchplugins for suite/mail

Non ebay changes are all image, and I'm just rubber stamping them. The ebay change is also a rubber stamp, but from a skim looks accurate.

Comment 15

[Théo Chevalier]

Thanks Justin

part 1, Fix desktop ebay search has landed earlier (verified fixed on 23):
http://hg.mozilla.org/l10n-central/fr/rev/f6e42a19b730
http://hg.mozilla.org/releases/l10n/mozilla-aurora/fr/rev/f6e42a19b730
http://hg.mozilla.org/releases/l10n/mozilla-beta/fr/rev/c319b36101f2

part 2, update searchplugins for suite/mail:
http://hg.mozilla.org/l10n-central/fr/rev/e3c62edb9755
http://hg.mozilla.org/releases/l10n/mozilla-aurora/fr/rev/b9aed606b855
http://hg.mozilla.org/releases/l10n/mozilla-beta/fr/rev/a9e7596b2ba3

Comment 16

[Théo Chevalier]

part 3, update ebay searchplugin for mobile
http://hg.mozilla.org/l10n-central/fr/rev/318131f43bb2
http://hg.mozilla.org/releases/l10n/mozilla-aurora/fr/rev/53535f239fac
http://hg.mozilla.org/releases/l10n/mozilla-beta/fr/rev/587b059133f0