Remove the top-30 frame restriction for signature generation

RESOLVED FIXED in 54

Status

Socorro
Backend
--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Scoobidiver (away), Unassigned)

Tracking

unspecified

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

(Reporter)

Description

5 years ago
_JNIEnv is in the skiplist but it's not taken into account in bp-15c3c62e-fd6c-4185-9dc0-337ab2130714 and bp-17dc8c04-52a2-42fa-bf80-242452130713.
arena_ is also in the skiplist but it's not taken into account in bp-a55f7255-b748-45f2-989e-6403b2130712 and bp-8b38776d-084d-43f1-97c1-133212130714.

It seems the combination of the ignore and skip lists doesn't work well.
Since 2009, signature generation has been limited to considering only the top 30 frames of a stack.  The reason behind this limitation appears to have been lost to history.

In each case in the aforementioned crashes, signature generation is correct when only the top thirty frames are considered.  In the first two, "_JNIEnv::CallStaticVoidMethod(_jclass*, _jmethodID*, ...)" is the 30th frame, so signature generation stops there.  

In the latter two cases, entries in the irrelevant_signature_re drop all most all of the first thirty frames from consideration leaving only the "arena_malloc" (and "arena_dalloc" in the last case) as the only input for signature generation.

If the 30 frame limit is no longer required, an enhancement request bug is should be filed for Socorro signature generation.
(Reporter)

Comment 2

5 years ago
The top-30 frame restriction made sense with desktop but not with Android.
Let's remove it.

Anyway, the signature in case of a long prefix skiplist is limited to 255 characters.
Severity: normal → enhancement
Summary: skiplist not taken into account in some cases → Remove the top-30 frame restriction for signature generation
(Reporter)

Updated

5 years ago
Blocks: 890590
Socorro PR 1337 (https://github.com/mozilla/socorro/pull/1337) removes the 30 frame restriction on signature generation.
Component: Infra → Backend
Target Milestone: --- → 54

Comment 4

5 years ago
Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/8e815571a454e68ef03756092ab38d149104a7c6
Merge pull request #1337 from twobraids/remove-thirty

fixes Bug 893585 - remove thirty frame signature restriction

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.