893740 - Make better use of Services.* in SeaMonkey's about.xhtml page

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[rsx11m]

+++ This bug was initially created as a clone of Bug #893547 +++

(Quoting Philip Chee from bug 893547 comment #11)
> > +      Components.utils.import("resource://gre/modules/Services.jsm");
> Can I suggest (perhaps in a followup bug):
> 1) Move the Services.jsm import to the top of the script.
> 2) Use Services for nsIURLFormatter, nsIXULAppInfo

Comment 1

[rsx11m]

Attachment: Proposed patch

Modifications as suggested, along with some blank-line removals.
This is only intended for comm-central.

Comment 2

[[e-mail]]

Comment on attachment 777529 [details] [diff] [review]
Proposed patch

>     <script type="application/javascript">
>       // get release notes URL and vendor URL from prefs
>+      Components.utils.import("resource://gre/modules/Services.jsm");
Really at the top please, and with a blank line before the comment to separate it too.

>+      var formatter = Services.urlFormatter;
...
>       var releaseNotesURL = formatter.formatURLPref("app.releaseNotesURL");
I know it might make the line a bit long but I'd prefer it if you just referenced Services.urlFormatter directly in both places.

Comment 3

[rsx11m]

Attachment: Patch for checkin

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/cf1808a78282