893830 - Implement mach uuid

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Graeme McCutcheon [:graememcc]]

Attachment: v1

Sometimes, asking firebot or remembering the name of your native OS command is just too much work.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 775675 [details] [diff] [review]
v1

Review of attachment 775675 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/mach_commands.py
@@ -10,4 @@
>      Command,
>  )
>  
> -

Does pep8 say anything about the number of empty lines here?

@@ +68,5 @@
> +    def uuid(self, format):
> +        import uuid
> +        u = uuid.uuid4()
> +        if format == 'idl':
> +          print(u)

4-space

@@ +73,5 @@
> +        else:
> +            u = u.hex
> +            print('{ 0x%s, 0x%s, 0x%s, \\' % (u[0:8], u[8:12], u[12:16]))
> +            pairs = tuple(map(lambda n: u[n:n+2], range(16, 32, 2)))
> +            print((' { ' + '0x%s, ' * 7 + '0x%s } }') % pairs)

Double space before the { to match http://mozilla.pettay.fi/cgi-bin/mozuuid.pl

Comment 2

[Graeme McCutcheon [:graememcc]]

Attachment: v2

> Does pep8 say anything about the number of empty lines here?
Bah, originally misguidedly placed my import up top; must have inadvertently deleted that line when moving the import.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 775703 [details] [diff] [review]
v2

Review of attachment 775703 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 4

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a639cb76d4d9

Comment 5

[Ed Morley [:emorley]]

graememcc++

Will be worth posting this on the newsgroups after it lands too :-)

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a639cb76d4d9

Comment 7

[Graeme McCutcheon [:graememcc]]

Attachment: Followup: output both forms by default

Following my post on planet, both mstange and njn have suggested that outputting both forms would be more useful. This would match Smaug's online tool, and the format parameter will still allow control of the output format.

I added c++ as a more natural format specification in addition to cpp.

Comment 8

[Gregory Szorc [:gps]]

Comment on attachment 777733 [details] [diff] [review]
Followup: output both forms by default

Review of attachment 777733 [details] [diff] [review]:
-----------------------------------------------------------------

WFM (with nits addressed).

::: tools/mach_commands.py
@@ +68,2 @@
>                       help='Output format for the generated uuid.')
>      def uuid(self, format):

You should say "format=None" because that argument will be passed by name, not position. You are getting lucky here because there is only 1 non-self argument and there's no potential for confusion.

@@ +73,2 @@
>              print(u)
> +            if format == None:

if format is None:

or

if not format:

Comment 9

[Graeme McCutcheon [:graememcc]]

You know those times when you intend to land a patch, forget to push it, and it lies gathering dust in Bugzilla for a few months? Yep. Mea culpa.

Pushed with nits addressed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/91690a35f26d

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/91690a35f26d