Closed Bug 89389 Opened 24 years ago Closed 23 years ago

"Save As Link..." improperly handles URLs that give 403 Forbidden or 404 Not Found

Categories

(Core Graveyard :: File Handling, defect)

Product:
Core Graveyard
Component:
File Handling
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Future

People

(Reporter: alexm, Assigned: bugzilla)

References

(
URL
)

Details

Attachments

(1 file, 2 obsolete files)

oh! I see what you meant.
2.14 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux 2.4.3 i686; en-US; rv:0.9) Gecko/20010505 BuildID: 2001050521 When I try to save a URL with "Save Link As...", and that URL gives HTTP error 403 Forbidden, the page with error message from the remote server (or proxy, as in my case), gets saved. Reproducible: Always Steps to Reproduce: 1. Go to the specified URL, http://cr.yp.to/crypto.html 2. Try to save the "Probability theory" link with right mouse button and "Save Link As..." 3. The 'prob.html' file gets saved. Actual Results: prob.html contains "<html><body>file does not exist</body></html>" Expected Results: Mozilla should clearly state that the file was not found on server or was forbidden, and do not save the file.
hmm I don't know about that.. what if you WANTED to save the error page? This is not User Interface Design.. trying Networking: HTTP but I recommend WONTFIX
Component: User Interface Design → Networking: HTTP
OS: Linux → All
Hardware: PC → All
> what if you WANTED to save the error page? I do think that 99% of users do not want to save (silently) the error page :) For those who do want, Mozilla could provide a button in error dialog.
ask: please don't forget to reassign... cc'ing mpt because we probably need some UID thoughts... Personally I would have made the same comments as ask.
Assignee: mpt → neeti
QA Contact: zach → benc
-> xpapss. I think that we should add error handling. If you want to save the page, you should be clicking on the link, seeing the html that came w/ the 4xx error, and then doing Save As (page)... Otherwise, people end up saving error pages that they thought was content.
Component: Networking: HTTP → XP Apps: GUI Features
don't forget to reassign! personally i'd settle for a dialog that says the page returned an error, would I like to save, view or cancel.
Assignee: neeti → blake
Status: UNCONFIRMED → NEW
Ever confirmed: true
QA Contact: benc → sairuh
Cool idea. usability/polish, 0.9.4.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.4
Target Milestone: mozilla0.9.4 → mozilla1.0
spam: over to File Handling. i have not changed the assigned developer [or the other fields for that matter], so if anyone realizes that a bug should have a more appropriate owner, go ahead and change it. :)
Component: XP Apps: GUI Features → File Handling
Target Milestone: mozilla1.0 → Future
Attached patch patch (obsolete) — — Splinter Review
Comment on attachment 69743 [details] [diff] [review] patch >+ promptService.alert(null, errorTitle, errorMsg); Shouldn't that first arg be "window" to properly have modality stuff set up?
Well, I don't have a handle to the window, this is the nsHeaderSniffer js "class"
Yeah. Just add the window to the "data" you initialize the header sniffer with....
Attached patch new patch (obsolete) — — Splinter Review
hmm...I guess. seems mildly lame that nsHeaderSniffer would take a window as an arg to its ctor.
Attachment #69743 - Attachment is obsolete: true
Attachment #69804 - Attachment is obsolete: true
Comment on attachment 69806 [details] [diff] [review] oh! I see what you meant. Yep, exactly. r=bzbarsky
Attachment #69806 - Flags: review+
JoeHew: sr=hewitt checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
vrfy'd fixed using 2002.02.18 comm bits on linux rh7.2, win2k and mac 10.1.2. now get an alert: "The link could not be saved. The web page might have been removed or had its name changed."
Status: RESOLVED → VERIFIED
For reference: this is broken again; see bug 174167 comment 10.
Yeah, because the header sniffer got nuked....
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: