Closed Bug 893910 Opened 7 years ago Closed 7 years ago

Current day failure count in data submission does not reset after 24-hour period

Categories

(Android Background Services Graveyard :: Firefox Health Report Service, defect)

ARM
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mcomella, Assigned: mcomella)

Details

Attachments

(1 file)

The code in SubmissionPolicy.tick(...) (https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/background/healthreport/upload/SubmissionPolicy.java#64) stores the current day failure count in the SharedPreferences (https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/background/healthreport/upload/SubmissionPolicy.java#286), persisting the value beyond the process' lifetime, but never checks if the argument localtime is 24 hours past the initial submission time (which can occur if the process is killed or the device is turned off).
^ needinfo is to continue the review on the PR from before.
LGTM.
Flags: needinfo?(rnewman)
Attached patch 893910.patchSplinter Review
Moved r+ (see rnewman above), review via github.
Attachment #783466 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/3d58bd987452
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.