893910 - Current day failure count in data submission does not reset after 24-hour period

Status: RESOLVED FIXED

(Android Background Services Graveyard :: Firefox Health Report Service, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The code in SubmissionPolicy.tick(...) (https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/background/healthreport/upload/SubmissionPolicy.java#64) stores the current day failure count in the SharedPreferences (https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/background/healthreport/upload/SubmissionPolicy.java#286), persisting the value beyond the process' lifetime, but never checks if the argument localtime is 24 hours past the initial submission time (which can occur if the process is killed or the device is turned off).

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://github.com/mozilla-services/android-sync/pull/329

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

^ needinfo is to continue the review on the PR from before.

Comment 3

[Richard Newman [:rnewman]]

LGTM.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: 893910.patch

Moved r+ (see rnewman above), review via github.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3d58bd987452

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3d58bd987452