Closed
Bug 893913
Opened 12 years ago
Closed 12 years ago
Not having MakeAPI breaks thimble loading (localhost)
Categories
(Webmaker Graveyard :: Thimble, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: michiel, Assigned: jon)
References
Details
Attachments
(1 file)
To just test Thimble without publication, there should be no need to spin up login/webmaker/makeapi. Right now the absence of the makeapi makes the page js-error which makes it unusable. We should fix this.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → jon
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #783196 -
Flags: review?(pomax)
Comment on attachment 783196 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/189
My name is Pomax and this is my favourite patch in the citadel.
Attachment #783196 -
Flags: review?(pomax) → review+
|
||
Comment 4•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org
https://github.com/mozilla/thimble.webmaker.org/commit/e6d5fbce024412b6c1a47a064254f5fb99a87f0c
Fix bug 893913 - Use local copy of makeapi client js
|
|
||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•