Closed
Bug 893994
Opened 10 years ago
Closed 10 years ago
Clicking Web developer widget multiple times can duplicate it's content when toolbar button is located in toolbar
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: ntim, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Australis:M8][Australis:P1])
Attachments
(3 files)
215.19 KB,
image/png
|
Details | |
2.41 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
1.48 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
What did you do? (steps to reproduce) : - Put the web developer button in toolbar - Click multiple times the button (happens randomly) What happened? (actual results) : - The contents between Toggle Tools and Connect duplicates What should have happened? (expected results) : - The contents shouldn't duplicate Additional info : - It shows an empty panel onblur
Reporter | ||
Updated•10 years ago
|
Blocks: australis-cust
Reporter | ||
Updated•10 years ago
|
Whiteboard: [Australis:M?]
Comment 1•10 years ago
|
||
Can you reproduce this with a new profile? Looks like you have have other addons involved here.
Whiteboard: [Australis:M?] → [Australis:M?][Australis:P1]
Assignee | ||
Comment 2•10 years ago
|
||
I can't reproduce this. The only way I think this could happen is if onViewShowing somehow fires more than once, but I don't see how that'd happen.
Assignee | ||
Comment 3•10 years ago
|
||
Huh, *can* reproduce on Windows (although rarely). Will investigate...
Assignee: nobody → gijskruitbosch+bugs
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee | ||
Comment 4•10 years ago
|
||
This fixes the issue, and also fixes us, I *think* never properly removing the listener (because bind returns another function, and we then referenced the original function in removeEventListener). AFAICT this fixes the issue at hand. I also think this attribute/property setting might be useful for styling the relevant buttons when their subviews are open, but that'd be a followup bug...
Attachment #777358 -
Flags: review?(mconley)
Assignee | ||
Comment 5•10 years ago
|
||
This is something else I noticed while investigating this: we nullcheck this._mainView fairly regularly in panelUI, so it's OK that it's sometimes null, but our code throws warnings because we pass an empty string to document.getElementById... :-(
Attachment #777363 -
Flags: review?(mconley)
Comment 6•10 years ago
|
||
Comment on attachment 777358 [details] [diff] [review] guard against opening a subview multiple times Review of attachment 777358 [details] [diff] [review]: ----------------------------------------------------------------- This looks reasonable to me. Good catch on that event listener not being removed - I hate those kind of bugs. :/
Attachment #777358 -
Flags: review?(mconley) → review+
Updated•10 years ago
|
Attachment #777363 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Pushed: https://hg.mozilla.org/projects/ux/rev/955e76aa16e7 https://hg.mozilla.org/projects/ux/rev/aea735296c81
Whiteboard: [Australis:M?][Australis:P1] → [Australis:M8][Australis:P1][fixed-in-ux]
Reporter | ||
Comment 8•10 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #7) > Pushed: > https://hg.mozilla.org/projects/ux/rev/955e76aa16e7 > https://hg.mozilla.org/projects/ux/rev/aea735296c81 I still can reproduce the bug in latest UX (17/07/13), but only when you double click really fast the button.
Assignee | ||
Comment 9•10 years ago
|
||
(In reply to ntim007 from comment #8) > (In reply to :Gijs Kruitbosch from comment #7) > > Pushed: > > https://hg.mozilla.org/projects/ux/rev/955e76aa16e7 > > https://hg.mozilla.org/projects/ux/rev/aea735296c81 > > I still can reproduce the bug in latest UX (17/07/13), but only when you > double click really fast the button. That'd be because these patches aren't in that nightly build yet. I even suspect they might not make today's (18th) build, which is starting in either 30 or 90 minutes, as the automated builds for that revision haven't finished yet. Patience! :-)
Assignee | ||
Comment 10•10 years ago
|
||
(In reply to ntim007 from comment #8) > (In reply to :Gijs Kruitbosch from comment #7) > > Pushed: > > https://hg.mozilla.org/projects/ux/rev/955e76aa16e7 > > https://hg.mozilla.org/projects/ux/rev/aea735296c81 > > I still can reproduce the bug in latest UX (17/07/13), but only when you > double click really fast the button. I'm not sure what platform you're on as you marked this bug all/all, but if you try the appropriate build for your platform: Windows: http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-win32/1374134388/firefox-25.0a1.en-US.win32.zip OS X: http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-macosx64/1374134388/firefox-25.0a1.en-US.mac.dmg Linux: http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-linux/1374134388/firefox-25.0a1.en-US.linux-i686.tar.bz2 Linux64: http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-linux64/1374134388/firefox-25.0a1.en-US.linux-x86_64.tar.bz2 It should be fixed.
Reporter | ||
Comment 11•10 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #10) > (In reply to ntim007 from comment #8) > > (In reply to :Gijs Kruitbosch from comment #7) > > > Pushed: > > > https://hg.mozilla.org/projects/ux/rev/955e76aa16e7 > > > https://hg.mozilla.org/projects/ux/rev/aea735296c81 > > > > I still can reproduce the bug in latest UX (17/07/13), but only when you > > double click really fast the button. > > I'm not sure what platform you're on as you marked this bug all/all, but if > you try the appropriate build for your platform: > > Windows: > http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-win32/ > 1374134388/firefox-25.0a1.en-US.win32.zip > > OS X: > http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-macosx64/ > 1374134388/firefox-25.0a1.en-US.mac.dmg > > Linux: > http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-linux/ > 1374134388/firefox-25.0a1.en-US.linux-i686.tar.bz2 > > Linux64: > http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-linux64/ > 1374134388/firefox-25.0a1.en-US.linux-x86_64.tar.bz2 > > > It should be fixed. I'm on Windows, I'll just wait for UX to update to 18/07/13 then.
Reporter | ||
Comment 12•10 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #10) > (In reply to ntim007 from comment #8) > > (In reply to :Gijs Kruitbosch from comment #7) > > > Pushed: > > > https://hg.mozilla.org/projects/ux/rev/955e76aa16e7 > > > https://hg.mozilla.org/projects/ux/rev/aea735296c81 > > > > I still can reproduce the bug in latest UX (17/07/13), but only when you > > double click really fast the button. > > I'm not sure what platform you're on as you marked this bug all/all, but if > you try the appropriate build for your platform: > > Windows: > http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-win32/ > 1374134388/firefox-25.0a1.en-US.win32.zip > > OS X: > http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-macosx64/ > 1374134388/firefox-25.0a1.en-US.mac.dmg > > Linux: > http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-linux/ > 1374134388/firefox-25.0a1.en-US.linux-i686.tar.bz2 > > Linux64: > http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-linux64/ > 1374134388/firefox-25.0a1.en-US.linux-x86_64.tar.bz2 > > > It should be fixed. The tinderbox build works perfectly :)
Assignee | ||
Comment 13•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/aea735296c81 https://hg.mozilla.org/mozilla-central/rev/955e76aa16e7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M8][Australis:P1][fixed-in-ux] → [Australis:M8][Australis:P1]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•