893994 - Clicking Web developer widget multiple times can duplicate it's content when toolbar button is located in toolbar

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Tim Nguyen :ntim]

Attachment: Screenshot of the bug

What did you do? (steps to reproduce) :
- Put the web developer button in toolbar
- Click multiple times the button (happens randomly) 	 

What happened? (actual results) :
- The contents between Toggle Tools and Connect duplicates

What should have happened? (expected results) :
- The contents shouldn't duplicate

Additional info :
- It shows an empty panel onblur

Comment 1

[Justin Dolske [:Dolske]]

Can you reproduce this with a new profile? Looks like you have have other addons involved here.

Comment 2

[:Gijs (he/him)]

I can't reproduce this. The only way I think this could happen is if onViewShowing somehow fires more than once, but I don't see how that'd happen.

Comment 3

[:Gijs (he/him)]

Huh, *can* reproduce on Windows (although rarely). Will investigate...

Comment 4

[:Gijs (he/him)]

Attachment: guard against opening a subview multiple times

This fixes the issue, and also fixes us, I *think* never properly removing the listener (because bind returns another function, and we then referenced the original function in removeEventListener). AFAICT this fixes the issue at hand. I also think this attribute/property setting might be useful for styling the relevant buttons when their subviews are open, but that'd be a followup bug...

Comment 5

[:Gijs (he/him)]

Attachment: avoid warnings for empty strings passed to document.getElementById when there's no mainView

This is something else I noticed while investigating this: we nullcheck this._mainView fairly regularly in panelUI, so it's OK that it's sometimes null, but our code throws warnings because we pass an empty string to document.getElementById... :-(

Comment 6

[Mike Conley (:mconley) (:⚙️) (PTO July 21 - 25)]

Comment on attachment 777358 [details] [diff] [review]
guard against opening a subview multiple times

Review of attachment 777358 [details] [diff] [review]:
-----------------------------------------------------------------

This looks reasonable to me. Good catch on that event listener not being removed - I hate those kind of bugs. :/

Comment 7

[:Gijs (he/him)]

Pushed:
https://hg.mozilla.org/projects/ux/rev/955e76aa16e7
https://hg.mozilla.org/projects/ux/rev/aea735296c81

Comment 8

[Tim Nguyen :ntim]

(In reply to :Gijs Kruitbosch from comment #7)
> Pushed:
> https://hg.mozilla.org/projects/ux/rev/955e76aa16e7
> https://hg.mozilla.org/projects/ux/rev/aea735296c81

I still can reproduce the bug in latest UX (17/07/13), but only when you double click really fast the button.

Comment 9

[:Gijs (he/him)]

(In reply to ntim007 from comment #8)
> (In reply to :Gijs Kruitbosch from comment #7)
> > Pushed:
> > https://hg.mozilla.org/projects/ux/rev/955e76aa16e7
> > https://hg.mozilla.org/projects/ux/rev/aea735296c81
> 
> I still can reproduce the bug in latest UX (17/07/13), but only when you
> double click really fast the button.

That'd be because these patches aren't in that nightly build yet. I even suspect they might not make today's (18th) build, which is starting in either 30 or 90 minutes, as the automated builds for that revision haven't finished yet. Patience! :-)

Comment 10

[:Gijs (he/him)]

(In reply to ntim007 from comment #8)
> (In reply to :Gijs Kruitbosch from comment #7)
> > Pushed:
> > https://hg.mozilla.org/projects/ux/rev/955e76aa16e7
> > https://hg.mozilla.org/projects/ux/rev/aea735296c81
> 
> I still can reproduce the bug in latest UX (17/07/13), but only when you
> double click really fast the button.

I'm not sure what platform you're on as you marked this bug all/all, but if you try the appropriate build for your platform:

Windows: http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-win32/1374134388/firefox-25.0a1.en-US.win32.zip

OS X: http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-macosx64/1374134388/firefox-25.0a1.en-US.mac.dmg

Linux: http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-linux/1374134388/firefox-25.0a1.en-US.linux-i686.tar.bz2

Linux64: http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-linux64/1374134388/firefox-25.0a1.en-US.linux-x86_64.tar.bz2


It should be fixed.

Comment 11

[Tim Nguyen :ntim]

(In reply to :Gijs Kruitbosch from comment #10)
> (In reply to ntim007 from comment #8)
> > (In reply to :Gijs Kruitbosch from comment #7)
> > > Pushed:
> > > https://hg.mozilla.org/projects/ux/rev/955e76aa16e7
> > > https://hg.mozilla.org/projects/ux/rev/aea735296c81
> > 
> > I still can reproduce the bug in latest UX (17/07/13), but only when you
> > double click really fast the button.
> 
> I'm not sure what platform you're on as you marked this bug all/all, but if
> you try the appropriate build for your platform:
> 
> Windows:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-win32/
> 1374134388/firefox-25.0a1.en-US.win32.zip
> 
> OS X:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-macosx64/
> 1374134388/firefox-25.0a1.en-US.mac.dmg
> 
> Linux:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-linux/
> 1374134388/firefox-25.0a1.en-US.linux-i686.tar.bz2
> 
> Linux64:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-linux64/
> 1374134388/firefox-25.0a1.en-US.linux-x86_64.tar.bz2
> 
> 
> It should be fixed.

I'm on Windows, I'll just wait for UX to update to 18/07/13 then.

Comment 12

[Tim Nguyen :ntim]

(In reply to :Gijs Kruitbosch from comment #10)
> (In reply to ntim007 from comment #8)
> > (In reply to :Gijs Kruitbosch from comment #7)
> > > Pushed:
> > > https://hg.mozilla.org/projects/ux/rev/955e76aa16e7
> > > https://hg.mozilla.org/projects/ux/rev/aea735296c81
> > 
> > I still can reproduce the bug in latest UX (17/07/13), but only when you
> > double click really fast the button.
> 
> I'm not sure what platform you're on as you marked this bug all/all, but if
> you try the appropriate build for your platform:
> 
> Windows:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-win32/
> 1374134388/firefox-25.0a1.en-US.win32.zip
> 
> OS X:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-macosx64/
> 1374134388/firefox-25.0a1.en-US.mac.dmg
> 
> Linux:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-linux/
> 1374134388/firefox-25.0a1.en-US.linux-i686.tar.bz2
> 
> Linux64:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/ux-linux64/
> 1374134388/firefox-25.0a1.en-US.linux-x86_64.tar.bz2
> 
> 
> It should be fixed.
The tinderbox build works perfectly :)

Comment 13

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/aea735296c81
https://hg.mozilla.org/mozilla-central/rev/955e76aa16e7