894080 - [B2G][l10n][Formatting] Croatian: The time format in calendar is displayed incorrect

Status: VERIFIED FIXED

(Mozilla Localizations :: hr / Croatian, defect)

Description

[Shilpa Suresh]

Attachment: Screenshot

Description:
The time format is displayed incorrectly (in AM/PM format) in Calendar app when user tries to create an event with the language set to Croatian

Repro Steps:
1) Updated Leo to Build ID: 20130715070218
2) Tap on calendar app
3) Tap on + sign(Add event) 
4) under 'All day event?', tap on time tab to change it 
5) On 'select time' screen, observe that the time format is incorrect(in AM/PM format)

Actual:
The time format is shown incorrectly in calendar app

Expected:
The time format is not shown incorrectly in calendar app

Environmental Variables
Build ID: 20130715070218
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6062fdf2deb8
Gaia: 55ed5e08a2250ea2d3571fff860c39e66fabed14
Platform Version: 18.1

Notes:
Repro frequency:  100%
See attached: screenshot

Comment 1

[Sasa Tekovic]

In apps/calendar/calendar.properties key 'hour-format' was accidentaly set to '%H'.

After consulting with date formats at http://pubs.opengroup.org/onlinepubs/007908799/xsh/strftime.html I guess the appropriate value should be '%R', since desired format should be HH:MM (24-hour format, for example 23:30).

I've corrected this and pushed the changes to the repo, however I'd like a second opinion about this one, therefore I'm CC-ing Axel. I hope I'm not bothering the wrong person :-)

Thanks!

Comment 2

[Delphine Lebédel [:delphine - Use needinfo]]

Asking for more info from Pike and also James, our calendar guy ;)
Also changing place for this bug.

Comment 3

[Francesco Lodolo [:flod]]

If en-US is %I %p, %H should be right for you. 

I think you're looking at the wrong variable: I have %H too in that file, and that screen shows hours in 24h format.

Comment 4

[Francesco Lodolo [:flod]]

This is the only %p I found in your locale, not sure about that thought considering it has %S too and there are no seconds in that dialog.

https://hg.mozilla.org/gaia-l10n/hr/file/00e459442281/shared/date/date.properties#l199

Comment 5

[Francesco Lodolo [:flod]]

Attachment: Screenshot Unagi with changed string

Firefox OS simulator is not reliable for this thing, it always displays 12 hours format. So I tried flashing my Unagi with Croatian.

If you make this change you get the right hour format in Calendar
dateTimeFormat_%X = %H:%M:%S

Comment 6

[Axel Hecht [:Pike]]

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/value_selector/value_selector.js#L498 has the magic.

12 hour format keys off of %p being part of the dateTimeFormat_%X string, in http://hg.mozilla.org/gaia-l10n/hr/file/00e459442281/shared/date/date.properties#l199.

So you want to set that to a non-am/pm format.

Comment 7

[Axel Hecht [:Pike]]

I'm moving this back to the Croatian localization now that we figured where the culprit is.

Comment 8

[Jason Smith [:jsmith]]

Give me one sec to fix the leo flag in the b2g component and I'll move it back to the localizations component.

Comment 9

[Sasa Tekovic]

Big thanks for everone who helped. I've corrected the time format and pushed changes to the repo. Marking as fixed.

Comment 10

[sarsenyev]

Verified on Leo V1.1. COM RIL,
The time is changed to 24 hours format in the Calendar app

Environmental  Variables:
Build ID: 20130809041203
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/45480132106b
Gaia: c9d0901564cf6f50e375ab48e4124b8378a2e246
Platform Version: 18.1
RIL Version: 01.01.00.019.184
Firmware verision: D300f080