894088 - Add argument for opening URL in new tab in GeckoView

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Shane Tully (:stully:]

The GeckoView loadUrl() should have an argument to request the URL be opened in a new tab. Otherwise, it's impossible to load any pages since the browser needs at least one open tab.

Comment 1

[Shane Tully (:stully:]

Attachment: 1/1 Add argument to loadUrl() function in GeckoView for opening URL in new tab

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

I don't think we should allow the basic GeckoView to support this until we add a way to select the active tab. I think that requires a Host implemented interface.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 775994 [details] [diff] [review]
1/1 Add argument to loadUrl() function in GeckoView for opening URL in new tab

as finkle said

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/d17e4a0cba94

Comment 5

[Shane Tully (:stully:]

> https://hg.mozilla.org/mozilla-central/rev/d17e4a0cba94

This is part of 880118. To copy the argument from that bug, this function is needed to get GeckoView to load a page when used as a library. Until a proper GeckoView interface is defined, it useful to have this otherwise GeckoView won't do anything interesting.