894129 - Move base/resources/xml-v11/preferences_customize_tablet.xml to resources/xml-xlarge-v11/preferences_customize.xml

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

Instead of using two different preferences in xml-v11, we should be (creating and) using the tablet-specific xml directory, xml-xlarge*.

Comment 1

[Chenxia Liu [:liuche]]

Attachment: Patch: move tablet res to xml-xlarge-v11 v1

Tablet uses xlarge res, so tablet resources in xml-v11 should instead be in xml-xlarge-v11.

Comment 2

[Chenxia Liu [:liuche]]

try build: https://tbpl.mozilla.org/?tree=Try&rev=cb0b0dfb8c13

Comment 3

[Chenxia Liu [:liuche]]

So it would appear that unfortunately, there are devices that are both multipane *and* don't use xlarge resources. That's the cause of the failure in the try push, on rc2. The device is using phone resources (which don't include Sync in a specific submenu) while being multipane, so the Sync menu item is not actually present.

I'll have to think about this one some more...

Comment 4

[Chenxia Liu [:liuche]]

Comment on attachment 776866 [details] [diff] [review]
Patch: move tablet res to xml-xlarge-v11 v1

Clearing review flag, since this is broken on certain phones that think they are tablets (or maybe the other way around). This may end up being a WONTFIX if Android doesn't provide enough fine-grained control.

Comment 5

[Chenxia Liu [:liuche]]

Sizing of tablets vs hi-res phones was still a problem last I looked at this, so WONTFIX-ing this.