894147 - Don't leak BrowserElementParent by holding a ref to it from an event handler registered on its window

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Justin Lebar (not reading bugmail)]

I put the Gaia fixes for bug 893012 into their own bug, so we might as well put the Gecko fix for that bug into its own bug.  I will move the attachment over here.

Comment 1

[Justin Lebar (not reading bugmail)]

Attachment: Patch, v1: Don't leak BrowserElementParent due to an event listener on the window which contains it.

khuey, want to do the honors here?

Comment 2

[Justin Lebar (not reading bugmail)]

https://hg.mozilla.org/projects/birch/rev/d23e2b6fb808

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d23e2b6fb808

"[jlebar will uplift]" - <3

Comment 4

[Justin Lebar (not reading bugmail)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/d95eb0b797a6

Comment 5

[Justin Lebar (not reading bugmail)]

Ah, crap, this has debugging stuff in it that we should *definitely* get rid of.

>     1.81 +  _gotLocationChange: function(data) {
>     1.82 +    this[data._payload_] = 'BEP location';
>     1.83 +    this._fireEventFromMsg(data);
>     1.84 +  },
>     1.85 +

This causes us to leak every URI until we close the frame.  :(

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Backed out due to debug mochitest orange.
https://hg.mozilla.org/releases/mozilla-b2g18/rev/1769cc7a08dc

https://tbpl.mozilla.org/php/getParsedLog.php?id=25450612&tree=Mozilla-B2g18
https://tbpl.mozilla.org/php/getParsedLog.php?id=25450681&tree=Mozilla-B2g18

Comment 7

[Justin Lebar (not reading bugmail)]

Dang, I got the tricky part of this merge right, but then I messed up the simple part.  This push should work.

I got rid of the debugging stuff from comment 5 in this push.  I'll push to m-c to get rid of it there, too.

https://hg.mozilla.org/releases/mozilla-b2g18/rev/54acb89975b5

Comment 8

[Justin Lebar (not reading bugmail)]

And pushed the debug-code removal to birch: https://hg.mozilla.org/projects/birch/rev/0d19bdaf4f2b

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/54acb89975b5

Comment 10

[Ryan VanderMeulen [:RyanVM]]

(In reply to Justin Lebar [:jlebar] from comment #8)
> And pushed the debug-code removal to birch:
> https://hg.mozilla.org/projects/birch/rev/0d19bdaf4f2b

https://hg.mozilla.org/mozilla-central/rev/0d19bdaf4f2b

Comment 11

[dkumar]

Can you please provide steps to verify this fix? - as we can perform blackbox testing from the UI