Closed Bug 894147 Opened 6 years ago Closed 6 years ago

Don't leak BrowserElementParent by holding a ref to it from an event handler registered on its window

Categories

(Firefox OS Graveyard :: General, defect)

defect
Not set

Tracking

(blocking-b2g:leo+, firefox23 wontfix, firefox24 wontfix, firefox25 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd fixed)

RESOLVED FIXED
1.1 QE4 (15jul)
blocking-b2g leo+
Tracking Status
firefox23 --- wontfix
firefox24 --- wontfix
firefox25 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix
b2g-v1.1hd --- fixed

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

References

Details

(Whiteboard: [MemShrink][LeoVB+] QARegressExclude)

Attachments

(1 file)

I put the Gaia fixes for bug 893012 into their own bug, so we might as well put the Gecko fix for that bug into its own bug.  I will move the attachment over here.
Whiteboard: [MemShrink]
Assignee: nobody → justin.lebar+bug
blocking-b2g: --- → leo+
https://hg.mozilla.org/projects/birch/rev/d23e2b6fb808
Whiteboard: [MemShrink] → [MemShrink][jlebar will uplift]
https://hg.mozilla.org/mozilla-central/rev/d23e2b6fb808

"[jlebar will uplift]" - <3
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/releases/mozilla-b2g18/rev/d95eb0b797a6
Whiteboard: [MemShrink][jlebar will uplift] → [MemShrink]
Target Milestone: --- → 1.1 QE4 (15jul)
Ah, crap, this has debugging stuff in it that we should *definitely* get rid of.

>     1.81 +  _gotLocationChange: function(data) {
>     1.82 +    this[data._payload_] = 'BEP location';
>     1.83 +    this._fireEventFromMsg(data);
>     1.84 +  },
>     1.85 +

This causes us to leak every URI until we close the frame.  :(
Dang, I got the tricky part of this merge right, but then I messed up the simple part.  This push should work.

I got rid of the debugging stuff from comment 5 in this push.  I'll push to m-c to get rid of it there, too.

https://hg.mozilla.org/releases/mozilla-b2g18/rev/54acb89975b5
And pushed the debug-code removal to birch: https://hg.mozilla.org/projects/birch/rev/0d19bdaf4f2b
(In reply to Justin Lebar [:jlebar] from comment #8)
> And pushed the debug-code removal to birch:
> https://hg.mozilla.org/projects/birch/rev/0d19bdaf4f2b

https://hg.mozilla.org/mozilla-central/rev/0d19bdaf4f2b
Can you please provide steps to verify this fix? - as we can perform blackbox testing from the UI
Whiteboard: [MemShrink] → [MemShrink][LeoVB+]
Whiteboard: [MemShrink][LeoVB+] → [MemShrink][LeoVB+] QARegressExclude
You need to log in before you can comment on or make changes to this bug.