894188 - "resetSupported is not defined" in safe mode dialog

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jesse Ruderman]

1. mkdir px/a/
2. While holding alt,
     firefox -profile ~/px/a/

Result:

JavaScript error: chrome://browser/content/safeMode.js, line 80: resetSupported is not defined

Probably a regression from https://hg.mozilla.org/mozilla-central/rev/37015ff213ae

safeMode.js might just need a
 -   resetSupported()
 +   ResetProfile.resetSupported()

Comment 1

[Matthew N. [:MattN]]

Attachment: v.1 update references to moved code and don't rely on import in other JS file

Comment 2

[Matthew N. [:MattN]]

Thanks. https://hg.mozilla.org/integration/mozilla-inbound/rev/135d3870f654

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/135d3870f654

Comment 4

[Simona Badau, Desktop QA]

I tried to verify this fix, but I don't get the same error as the one mentioned in the Description (when following the steps from the Description). 

Just to be sure I got it right, is the px directory created in the profiles directory? Could you please give me some more details?

Comment 5

[Jesse Ruderman]

I'm just creating ~/px/ and ~/px/a/ in order to use ~/px/a/ as a fresh, disposable Firefox profile.

[-P name] would use a subdirectory of the profiles directory, but [-profile dir] uses just the specified directory.

Comment 6

[Jesse Ruderman]

If you don't hold Alt, you should see files like places.sqlite appear in the profile directory.

If you do hold Alt (might be Shift instead on Windows?), you should see a Safe Mode dialog.