894224 - Australis tabs separators are too faint

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Ivan Alagenchev :ialagenchev]

Attachment: A screenshot showing the problem

I just downloaded the australis version of ffox and noticed that the window tabs are a bit too faint. I am having hard time distinguishing where a tab begins and where a tab ends. This creates a problem in the following use cases: 
1) My monitor contrast is not perfect for the chosen graphical design
2) A second user looking at my screen - family member, student etc
3) A privacy screen installed on the monitor

In all of the above circumstances the tab borders are indistinguishable.

Comment 1

[Ivan Alagenchev :ialagenchev]

Please make the separators more distinguishable.

Comment 2

[Justin Dolske [:Dolske]]

This is per spec, the subtle appearance of background tabs is intentional.

http://people.mozilla.com/~shorlander/files/australis-designSpecs/australis-designSpecs-windows7-mainWindow.html

Comment 3

[Ivan Alagenchev :ialagenchev]

(In reply to Justin Dolske [:Dolske] from comment #2)
> This is per spec, the subtle appearance of background tabs is intentional.
> 
> http://people.mozilla.com/~shorlander/files/australis-designSpecs/australis-
> designSpecs-windows7-mainWindow.html

I expected this to be per spec. My bug is about specific shortcomings in the design/spec. The current design could also be an issue with people who are visually impaired. Has the design been evaluated for accessibility? 

I understand that you might not have the answers to all questions that I'm asking. Would you mind triaging to the right people if that's the case?

Comment 4

[Justin Dolske [:Dolske]]

I think the current design has made appropriate considerations and tradeoffs. If it's actually a big problem, we can reevaluate post-landing.

Comment 5

[Ivan Alagenchev :ialagenchev]

(In reply to Justin Dolske [:Dolske] from comment #4)
> I think the current design has made appropriate considerations and
> tradeoffs. If it's actually a big problem, we can reevaluate post-landing.

I see. Thank you for your consideration and your time.

Comment 6

[Stephen Horlander [:shorlander]]

I think we could probably tweak the contrast on them to make them more obvious. They are a little too faint.

Comment 7

[Ivan Alagenchev :ialagenchev]

(In reply to Stephen Horlander [:shorlander] from comment #6)
> I think we could probably tweak the contrast on them to make them more
> obvious. They are a little too faint.

Awesome! Thank you soooo much.

Comment 8

[Jesse Ruderman]

The faint separators work well as long as you only visit sites with strong favicons.

Comment 9

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: Tab_separators.zip

Updated attached.

Comment 10

[Matthew N. [:MattN]]

Attachment: v.1 OS X image swap

I confirmed that the images were the same size and just differed in the strength.

Comment 11

[Matthew N. [:MattN]]

Attachment: v.1 Windows and Linux image swap

Michael, I have two questions about attachment 8386273 [details]:
* Linux: Was it intentional that the separator is no longer a gradient? This doesn't match the tab overflow separator. Also note that the previous image and your new one both are quite a bit darker than the nav-bar top border. On the other platforms the colors are more similar.
* Windows: You provided directories named Windows XP, Windows 7, & Windows 8 while images were needed for Luna Blue, Aero, and the default for everything else. I mapped them corresponding to the order I wrote the two lists above. Was that correct?

More context:
* Luna blue is one of three non-classic themes on XP
* Aero is used on Windows Vista and up (including 8)
* The default tab-separator.png would be used on Windows Classic themes, non-Luna Blue XP themes (e.g. Silver and Olive green).

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8405857 [details] [diff] [review]
v.1 OS X image swap

Review of attachment 8405857 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8405858 [details] [diff] [review]
v.1 Windows and Linux image swap

Review of attachment 8405858 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me depending on the response from mmaslaney

Comment 14

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: -Assets.zip

Updated Separators for the following platforms:

Linux
Windows
Windows-aero
Windows-luna-blue

The attached updates are based on the images from:
https://mxr.mozilla.org/mozilla-central/find?string=tab-separator&tree=mozilla-central&hint=

Comment 15

[Michael Maslaney [:mmaslaney] ([e-mail])]

Comment on attachment 8405858 [details] [diff] [review]
v.1 Windows and Linux image swap

Updated the bug with new separators.

Comment 16

[Jared Wein [:jaws] (please needinfo? me)]

Flagging Matt so this doesn't get forgotten about.

Comment 18

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: -Assets.zip

Updated the Aero theme

Comment 19

[Dão Gottwald [:dao]]

Is this ready to land?

Comment 20

[Matthew N. [:MattN]]

I haven't looked at the new images yet to see if they are what are needed. I meant to finish this last week.

Marco, can you add this to the current iteration, it's overdue.

Comment 21

[Marco Mucci [:MarcoM]]

Added to Iteration 32.3

Comment 22

[Marco Mucci [:MarcoM]]

Hi Matthew, any recommendation if this bug should be set to [qa+] or [qa-] for verification.

Comment 23

[Matthew N. [:MattN]]

Attachment: v.2 Windows and Linux image swap

Images from attachment 8422515 [details].

Comment 24

[Matthew N. [:MattN]]

(In reply to Marco Mucci [:MarcoM] from comment #22)
> Hi Matthew, any recommendation if this bug should be set to [qa+] or [qa-]
> for verification.

Since it's just an image swap and I verified the images are the same size, I don't think QA is necessary.

Comment 25

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8431329 [details] [diff] [review]
v.2 Windows and Linux image swap

Review of attachment 8431329 [details] [diff] [review]:
-----------------------------------------------------------------

Tested on Windows 8, this looks a lot better. Thanks :)

Comment 26

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/14ba825163a9
Folded patches pushed

Comment 27

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/14ba825163a9