Closed
Bug 894239
Opened 12 years ago
Closed 12 years ago
[Clock] Update icon which be provide via UX team for assets @1.5
Categories
(Firefox OS Graveyard :: Gaia::Clock, defect)
Tracking
(blocking-b2g:hd+, b2g-v1.1hd fixed)
People
(Reporter: iliu, Assigned: iliu)
Details
Attachments
(2 files, 1 obsolete file)
These icon should be updated via UX team's assets.
Assignee | ||
Comment 1•12 years ago
|
||
Rex,
Could you please help to review my pr? Thanks.
The patch works for Gaia master.
Attachment #776227 -
Flags: review?(rexboy)
Assignee | ||
Comment 2•12 years ago
|
||
Comment on attachment 776227 [details]
pointer to Github pr 10998
<!DOCTYPE html><meta charset="utf-8"><meta http-equiv="refresh" content="5;https://github.com/mozilla-b2g/gaia/pull/10998"><title>Bugzilla Code Review</title><p>You can review this patch at <a href="https://github.com/mozilla-b2g/gaia/pull/10722">https://github.com/mozilla-b2g/gaia/pull/10998</a>, or wait 5 seconds to be redirected there automatically.</p>
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 776227 [details]
pointer to Github pr 10998
><!DOCTYPE html><meta charset="utf-8"><meta http-equiv="refresh" content="5;https://github.com/mozilla-b2g/gaia/pull/10722"><title>Bugzilla Code Review</title><p>You can review this patch at <a href="https://github.com/mozilla-b2g/gaia/pull/10722">https://github.com/mozilla-b2g/gaia/pull/10722</a>, or wait 5 seconds to be redirected there automatically.</p>
Assignee | ||
Comment 4•12 years ago
|
||
Comment on attachment 776227 [details]
pointer to Github pr 10998
Sorry, please ignore the pr and above useless comment. I'll attach another link.
Attachment #776227 -
Attachment filename: Pointer to Github pull request 10998.txt → Pointer to Github pull request 10998.html
Attachment #776227 -
Attachment is obsolete: true
Attachment #776227 -
Flags: review?(rexboy)
Assignee | ||
Comment 5•12 years ago
|
||
Please help to review the pr for Gaia master. Thanks.
Attachment #776239 -
Flags: review?(rexboy)
Assignee | ||
Comment 6•12 years ago
|
||
Rex,
Please help to review the pr for Gaia v1.1.0hd. Thanks you again.
Attachment #776243 -
Flags: review?(rexboy)
Comment 8•12 years ago
|
||
Comment on attachment 776239 [details]
pointer to Github pr 10998
r=me
thanks for your patch!
Attachment #776239 -
Flags: review?(rexboy) → review+
Updated•12 years ago
|
Attachment #776243 -
Flags: review?(rexboy) → review+
Assignee | ||
Comment 9•12 years ago
|
||
Thanks for Rex's reviewing effort. Since the two prs were merged, we can close the issue now.
master: f8740f5cd78f44a1063463cd96794f124c5b754e
v1.1.0hd: 115a5ca86cd225bef4292652501446d05213e6b6
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
![]() |
||
Comment 10•12 years ago
|
||
[2013/10/21 Helix Testing]
Gaia: c829a2042594b6c3a4899ee27979799a0f301534
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/f7c657f6d019
BuildID 20131015042201
Version 18.0
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•