894275 - [Buri][Call log]It go to another contact when press a contact in call log.

Status: RESOLVED DUPLICATE of bug 893269

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[sync-1]

AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.152
 Firefox os  v1.1
 Mozilla build ID:20130702230206
 
 Created an attachment (id=459726)
 log
 
 DEFECT DESCRIPTION:
 [Call log]It go to another contact when press a contact in call log.
 
  REPRODUCING PROCEDURES:
 1.Open some contacts to check
 2.There exist some call log with different contact(eg:A,B)
 3.press contact A
 4.Pop up contact B--KO
 
  EXPECTED BEHAVIOUR:
 It should be pop up right contact.
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 1/8
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: log

Comment 3

[Leo]

Is this issue similar to Bug 893269?

Comment 5

[Mingming ZHAO]

I think this is not similar to bug 893269.

First reproduce this issue like this:
1.save a number as A to Contacts
3.open Dialer -> open rencent call log
4.incoming a call from A do not answer it, until the call disconnect
5.click the missed call -> it will open anther contact
6.the reproducing rate is 50%
7.if this issue not happen,anther issue maybe will happen. The issue is: the A contact is opened success, but when you click Edit, it maybe will not open Edit contact, but Add contact.

Comment 6

[Mingming ZHAO]

I investigeted this issue, the codes is executed like this:
 
https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/communications/dialer/js/handled_call.js#L282
|
|
https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/communications/dialer/js/oncall.js#L755
|
|
https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/communications/dialer/js/dialer.js#L265
|
|
https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/communications/dialer/js/dialer.js#L132
|
|
https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/communications/dialer/js/call_log_db.js#L376
|
|
https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/communications/dialer/js/call_log.js#L212
|
|
https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/communications/dialer/js/call_log.js#L220
|
|
https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/communications/dialer/js/call_log.js#L321
|
|
https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/communications/dialer/js/call_log.js#L408
|
|
https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/communications/dialer/js/call_log.js#L465
|
|
https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/communications/dialer/js/call_log.js#L522

Now the "params.contact.id" is null, the reason is the parameter "params" is come from "https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/communications/dialer/js/handled_call.js#L282", but there has not "contact.id" in "entry".

So when click the call log item, it will execute "https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/communications/dialer/js/call_log.js#L581" , because of the "dataset.contactId" is null, so it will not open the contact correct.

Comment 7

[Mingming ZHAO]

Maybe can fix this issue like this:

--- a/apps/communications/dialer/js/handled_call.js
+++ b/apps/communications/dialer/js/handled_call.js
@@ -136,7 +136,8 @@ HandledCall.prototype.updateCallNumber = function hc_updateCallNumber() {
       var contactCopy = {
         name: contact.name,
         org: contact.org,
-        tel: contact.tel
+        tel: contact.tel,
+        id: contact.id           //TCL_zmm  fix pr_490877 487767
       };
       if (primaryInfo) {
         node.textContent = primaryInfo;